go-sql-driver / mysql / 26049355567

83%

master: 83%

Pull #1769

github

result: don't panic when affectedRows/insertIds are empty

Closes #1733.

mysqlResult.LastInsertId / RowsAffected indexed into their slices
without checking length, so any code path that left the result slices
empty (e.g. an error before the affected-rows packet) panicked the
caller. Return 0, nil instead, which matches the database/sql.Result
contract for 'no rows affected'.

Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

3384 of 4091 relevant lines covered (82.72%)

2621745.87 hits per line