go-pkgz / requester

92%

main: 88%

LAST BUILD ON BRANCH fix/cache-key-host

branch: fix/cache-key-host

CHANGE BRANCH

x

Reset

• fix/cache-key-host
• chore/example-deps
• chore/go-fix
• chore/update-deps
• ci/lift-actions
• fix-ci-caching
• fix/redirect-credential-leak
• fix/with-middleware-aliasing
• initernal-middlewares
• main
• master
• refs/tags/v0.0.1
• refs/tags/v0.0.2
• refs/tags/v0.0.3
• refs/tags/v0.0.4
• refs/tags/v0.1.0
• refs/tags/v0.2.0
• refs/tags/v0.2.1
• refs/tags/v0.3.0
• refs/tags/v0.4.0
• refs/tags/v0.4.1
• refs/tags/v0.5.0
• repater-no-codes
• switch-to-repeater-v2

Build # 32204538087

Build Type

Pull #9

github

Committed by paskal

Commit Message

fix: include the effective host in the cache key

Both cache middlewares keyed responses on the URL only, so requests
differing solely by Request.Host shared a cache entry and a response
cached for one virtual host was served for another one.

The key now carries the effective host, Request.Host when set and the URL
host otherwise, and every part goes in as a length-prefixed field so a
value of one part can't be read as another one.

Pull Request Pull Request #9: fix: include the effective host in the cache key

Coverage Stats

40 of 40 new or added lines in 2 files covered. (100.0%)

545 of 590 relevant lines covered (92.37%)

18.91 hits per line