go-pkgz / requester

93%

main: 88%

push

github

fix: close retried responses in retry middleware (#16)

Retry kept a response it decided to retry in lastResponse and looped, and
nothing closed its body. Each retried response held one TCP connection and
its transport goroutines for the lifetime of the client.

RoundTrip closes the body of a response dropped in favor of another attempt,
for a retryable status and for a response returned together with an error.
The response of the last attempt is returned to the caller open, as before.

The body is closed without draining. A read in the middleware has no time
bound and would block the retry when an upstream sends headers and stalls
the body. The go1.27.1 transport drains on close within its own limits and
reuses the connection. The go1.25.0 transport does not, so there a retried
response costs a new connection, which is closed and no longer leaked.

Related to #15

12 of 12 new or added lines in 1 file covered. (100.0%)

590 of 636 relevant lines covered (92.77%)

21.63 hits per line