florianl / go-tc
92%

DEFAULT BRANCH: main
Repo Added
Files 84
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 92.357% (-0.1%) from 92.479%
40076170815

push

github

web-flow 
netem: parse kind-specific extended statistics (#341)

* netem: parse kind-specific extended statistics

netem exports its extended statistics (struct tc_netem_xstats) via
TCA_STATS_APP (netem_dump_stats() calls gnet_stats_copy_app()), and
some setups expose it via TCA_XSTATS. Both paths aborted the whole
qdisc dump parse so far:

- extractXStats() had no "netem" case -> "extractXStats(): unsupported kind: netem"
- unmarshalGenStats() hit the default case for TCA_STATS_APP
  -> "unmarshalGenStats()\t4"

containerlab tools netem set/show depends on Qdisc().Get() and fails
with those messages although the netem qdisc itself is created fine.

This parses the kind-specific payload for netem on both attribute
paths (unit tests included) and keeps unknown TCA_STATS_APP payloads
without aborting the dump.

Signed-off-by: Sebastian Rieger <sebastian.rieger@informatik.hs-fulda.de>

* stats: keep TCA_STATS_APP payload out of the public API

Instead of exposing the raw TCA_STATS_APP payload as GenStats.App []byte,
buffer it while walking the attributes and parse it kind-specifically after
the whole netlink message has been walked (same pattern as TCA_XSTATS).

This also fixes an attribute-order dependency: netem dumps may carry
tcaStats2 before tcaKind, so the kind-specific parsing must not happen
inline at the tcaStats2 case.

Signed-off-by: Sebastian Rieger <sebastian.rieger@informatik.hs-fulda.de>

* q_netem: harden extractTcmsgAttributes for truncated/oversized APP payloads

- treat a zero-length APP payload as absent instead of returning
  io.ErrUnexpectedEOF
- fail on APP payloads whose declared length does not match the
  remaining message bytes
- report the truncated attribute explicitly and skip it instead of
  silently continuing
- return an error for unknown attribute kinds that carry an APP
  payload

Signed-off-by: Sebastian Rieger <sebastian.rieger@informatik.hs-fulda.de>

---------

Signed-off-by: Sebastian Rieger <sebastian.rieger@informatik.hs-fulda.de>

24 of 27 new or added lines in 4 files covered. (88.89%)

5 existing lines in 3 files now uncovered.

4882 of 5286 relevant lines covered (92.36%)

11.24 hits per line

Relevant lines Covered
5286 RELEVANT LINES 4882 COVERED LINES
11.24 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
40076170815 main netem: parse kind-specific extended statistics (#341) * netem: parse kind-specific extended statistics netem exports its extended statistics (struct tc_netem_xstats) via TCA_STATS_APP (netem_dump_stats() calls gnet_stats_copy_app()), and some se... push web-flow github
92.36
39154242294 netem-xstats q_netem: harden extractTcmsgAttributes for truncated/oversized APP payloads - treat a zero-length APP payload as absent instead of returning io.ErrUnexpectedEOF - fail on APP payloads whose declared length does not match the remaining message... Pull #341 srieger1 github
92.36
39046409673 main CI: fix code-check failure (#344) Signed-off-by: Florian Lehner <dev@der-flo.net> push web-flow github
92.48
39046248173 fix-code-check CI: fix code-check failure Signed-off-by: Florian Lehner <dev@der-flo.net> Pull #344 florianl github
92.48
39045858137 main build(deps): bump actions/download-artifact from 8.0.1 to 8.0.2 (#343) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 8.0.1 to 8.0.2. - [Release notes](https://github.com/actions/download-artifact/releases) -... push web-flow github
92.48
39045782553 main build(deps): bump actions/upload-artifact from 7.0.1 to 7.0.2 (#342) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commit... push web-flow github
92.48
38967839812 netem-xstats stats: keep TCA_STATS_APP payload out of the public API Instead of exposing the raw TCA_STATS_APP payload as GenStats.App []byte, buffer it while walking the attributes and parse it kind-specifically after the whole netlink message has been walke... Pull #341 srieger1 github
92.35
38966646845 netem-xstats stats: keep TCA_STATS_APP payload out of the public API Instead of exposing the raw TCA_STATS_APP payload as GenStats.App []byte, buffer it while walking the attributes and parse it kind-specifically after the whole netlink message has been walke... Pull #341 srieger1 github
92.35
38444325642 dependabot/github_actions/actions/upload-artifact-7.0.2 build(deps): bump actions/upload-artifact from 7.0.1 to 7.0.2 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](http... Pull #342 web-flow github
92.48
38444355188 dependabot/github_actions/actions/download-artifact-8.0.2 build(deps): bump actions/download-artifact from 8.0.1 to 8.0.2 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 8.0.1 to 8.0.2. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commi... Pull #343 web-flow github
92.48
See All Builds (788)