eaburns / T

88%

master: 88%

LAST BUILD ON BRANCH scroll

branch: scroll

CHANGE BRANCH

x

Reset

• scroll
• address
• addrs
• aggregate_errors
• block
• bugs
• coveralls
• edit
• editor
• fix-osx
• gofont
• goveralls
• master
• metrics
• new_ui
• race
• re1
• revert
• shiny_gui
• silence_log
• text
• text_optimizations
• text_size
• the_clamps
• toolcover
• travis
• ui
• ui_move_dot
• view
• websocket

Build # 1391

Build Type

push

travis-ci

Committed by eaburns

Commit Message

editor/view,ui: return errors preforming edits on a View.

We were returning errors from individual edits, but if the entire HTTP request failed, no error was returned, and the response channel was never notified. This caused any such error to deadlock waiting for a response that would never be sent. Now, the interface is changed to hide the underlying channel and simply return the response or an error instead.

This change also makes the ui code more explicit about whether it's doing a synchronous or asynchornous request. This is important, because we want to avoid blocking the window's event goroutine on synchronous requests, which we currently do in a few places (see #295).

Fixes #293.

Run Details

3890 of 4413 relevant lines covered (88.15%)

2.13 hits per line