1391
88%
master: 88%

Ran 04 May 2016 06:51PM UTC

Jobs 1

Files 19

Run time 27s

Badge

Embed ▾

pending completion

Build # 1391

Build Type

push

travis-ci

Committed by

eaburns

Commit Message

editor/view,ui: return errors preforming edits on a View.

We were returning errors from individual edits, but if the entire HTTP request failed, no error was returned, and the response channel was never notified. This caused any such error to deadlock waiting for a response that would never be sent. Now, the interface is changed to hide the underlying channel and simply return the response or an error instead.

This change also makes the ui code more explicit about whether it's doing a synchronous or asynchornous request. This is important, because we want to avoid blocking the window's event goroutine on synchronous requests, which we currently do in a few places (see #295).

Fixes #293.

Run Details

3890 of 4413 relevant lines covered (88.15%)

2.13 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1391.1 (PATH=$HOME/gopath/bin:$PATH)	04 May 2016 06:51PM UTC	0	88.15	Travis Job 1391.1

Source Files on build 1391

Detailed source file information is not available for this build.

eaburns / T / 1391
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1391

eaburns / T / 1391 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1391

eaburns / T / 1391
88%
master: 88%

README BADGES
x