dgilland / pydash

100%

LAST BUILD ON BRANCH develop

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• develop
• feature-performance
• feature-v2
• feature-v3
• feature-v5
• fix-coveralls
• fix-flatten-iterables-171
• fix-intersperse-empty
• fix-restricted-dunder-keys-240
• fix/take-drop-while-generator
• fix/to-list-dict-values
• master
• revert-107-develop
• typehints
• v0.0.0
• v1.0.0
• v1.1.0
• v2.0.0
• v2.1.0
• v2.2.0
• v2.3.0
• v2.3.1
• v2.3.2
• v2.4.0
• v2.4.1
• v2.4.2
• v3.0.0
• v3.0.1
• v3.1.0
• v3.2.0
• v3.2.1
• v3.2.2
• v3.3.0
• v3.4.0
• v3.4.2
• v3.4.3
• v3.4.4
• v3.4.5
• v3.4.6
• v3.4.7
• v3.4.8
• v4.0.0
• v4.0.1
• v4.0.2
• v4.0.3
• v4.0.4
• v4.1.0
• v4.2.0
• v4.2.1
• v4.3.0
• v4.3.1
• v4.3.2
• v4.3.3
• v4.4.0
• v4.4.1
• v4.5.0
• v4.6.0
• v4.6.1
• v4.7.0
• v4.7.1
• v4.7.2
• v4.7.3
• v4.7.4
• v4.7.5
• v4.7.6
• v4.8.0
• v4.9.0
• v5.0.1
• v5.0.2
• v5.1.0
• v5.1.1
• v5.1.2
• v6.0.0
• v6.0.1
• v6.0.2
• v7.0.0
• v7.0.1
• v7.0.2
• v7.0.4
• v7.0.5
• v7.0.6
• v7.0.7
• v8.0.0
• v8.0.1
• v8.0.2
• v8.0.3
• v8.0.4
• v8.0.5
• v8.0.6

Build # 28823963307

Build Type

push

github

Committed by web-flow

Commit Message

fix: floor/ceil/round_ used as iteratees pass index as precision (#248)

pydash.floor, pydash.ceil, and pydash.round_ each accept an optional
`precision` argument.  helpers.getargcount() counts all positional
parameters, so it returns 2 for these functions.  When callit() then
invokes them with (element, index, collection) it passes the collection
index as `precision`, producing wrong grouping keys.

For example:
    count_by([6.1, 4.2, 6.3], floor)
returned {6.0: 1, 4.2: 1, 6.3: 1} instead of {6.0: 2, 4.0: 1}
because floor(4.2, 1) == 4.2 and floor(6.3, 2) == 6.3.

Setting _argcount = 1 on all three functions signals callit() to supply
only the element value, matching the intent of using them as iteratees.

Co-authored-by: Derrick Gilland <dgilland@gmail.com>

Coverage Stats

12758 of 12758 relevant lines covered (100.0%)

1.0 hits per line