decentraland / social-service-ea

89%

main: 90%

LAST BUILD ON BRANCH fix/unexpected-community-privacy-update

branch: fix/unexpected-community-privacy-update

CHANGE BRANCH

x

Reset

Sync Branches

• fix/unexpected-community-privacy-update
• 0.0.1
• 0.0.2
• 0.1.0
• 0.10.0
• 0.11.0
• 0.12.0
• 0.13.0
• 0.14.0
• 0.15.0
• 0.16.0
• 0.18.0
• 0.19.0
• 0.19.1
• 0.2.0
• 0.2.1
• 0.20.0
• 0.21.0
• 0.21.1
• 0.3.0
• 0.4.0
• 0.4.1
• 0.4.2
• 0.4.3
• 0.4.4
• 0.4.5
• 0.5.0
• 0.6.0
• 0.7.0
• 0.8.0
• 0.8.1
• 0.9.0
• 1.0.0
• 1.0.1
• 1.0.2
• 1.0.3
• chore/add-logs-in-ws-pool
• chore/add-logs-to-catalyst-client
• chore/add-logs-to-rpc
• chore/coveralls-configuration
• chore/debug-deployment
• chore/enhance-logs
• chore/enhance-readme-and-setup-for-new-contributors
• chore/log-time-to-get-cached-profile
• chore/lower-trace-sample-rate-sentry
• chore/shorten-readme
• docs/add-missing-endpoints
• docs/bundle-api-specs
• docs/deploying-preview
• docs/missing-field-in-community-creation
• docs/openapi-bans-endpoints
• docs/openapi-endpoints
• docs/update-http-server-url
• docs/ws-updates-handling
• feat/accept-call-request
• feat/adapt-rpc-services-with-enhanced-errors
• feat/add-analytics
• feat/add-communities-voice-chat-info
• feat/add-finalize-referral-process
• feat/add-log-messages
• feat/add-logs
• feat/add-privacy-settings-endpoint
• feat/add-remove-places-from-community
• feat/add-slack-notification-reaching-100-invited-users
• feat/add-social-settings-rpc-handlers
• feat/add-ws-transport-error-metrics
• feat/adjust-permisions-on-actions
• feat/adjust-ports-on-svs
• feat/all-active-voice-chats
• feat/allow-global-moderators-to-remove-communities
• feat/allow-self-demoting
• feat/atp-validator
• feat/blocks
• feat/bump-protocol-experimental
• feat/check-community-calls-ongoing
• feat/communities-events
• feat/communities-invites
• feat/communities-members
• feat/communities-requests-reaction
• feat/communities-voice-chat
• feat/communities-with-active-voice-chats
• feat/community-compliance-with-ai
• feat/community-invites-restrictions
• feat/community-members-ws-updates
• feat/community-users-voice-chat-banned-users
• feat/community-voice-chat-actions
• feat/community-voice-chat-end-notification
• feat/community-voice-chat-position
• feat/denylist
• feat/end-community-call
• feat/enhance-metrics
• feat/enhance-updates-metrics
• feat/enhance-ws-handler
• feat/events-on-communities
• feat/expire-private-voice-chats
• feat/expose-new-endpoint-to-list-all-communities-for-global-moderators
• feat/fail-fast-on-self-friendship-reqs
• feat/fetch-member-requests
• feat/filter-friends-by-connectivity-status
• feat/get-and-delete-communities
• feat/get-banned-users
• feat/get-communities
• feat/get-community-places
• feat/get-friends-optimizations
• feat/get-friendship-requests-optimizations
• feat/get-incoming-rpivate-voice-chat-requests
• feat/get-online-members-from-community
• feat/get-public-communities
• feat/hook-message-processor-to-different-event
• feat/implement-get-online-friends-rpc
• feat/implement-new-protocol-definition
• feat/improve-possible-race-conditions
• feat/include-friendship-status-when-getting-members
• feat/include-if-user-is-friend-in-privacy-settings
• feat/include-owner-name-in-communities
• feat/increase-signature-expiration-time
• feat/initial-communities-migrations
• feat/integrate-sentry
• feat/invalidate-thumbnails-cache-on-updates
• feat/invites-to-community
• feat/kick-ban-from-comm-voice-chats
• feat/make-thumbnails-optional
• feat/manage-requests-statuses
• feat/managed-communities-retrieval
• feat/members-of-public-communities-without-signed-fetch
• feat/merge-referral-server
• feat/missing-indexes
• feat/missing-indexes-for-get-requests-queries
• feat/more-ai-compliance-optimizations
• feat/more-optimizations
• feat/mute-community-voice-chat
• feat/normalize-addresses-on-db
• feat/notify-connectivity-when-user-accepts-request
• feat/notify-join-on-requests
• feat/notify-on-friendhsip-request
• feat/notify-when-community-removed-because-content-violation
• feat/on-cleanup-return-if-redis-already-closed
• feat/on-upserting-communities-validate-first
• feat/optimize-catalyst-calls-when-retrieving-communities-owners
• feat/optimize-compliance-prompt
• feat/optimize-queries-avoiding-joining-bans
• feat/optimize-updates-when-deleting-communities
• feat/owner-name-on-communities
• feat/private-communities-creation-and-edition
• feat/private-communities-exposure-4-admins
• feat/referral-login-days-process
• feat/referral-notif
• feat/reject-call-request
• feat/reject-request-to-speak
• feat/remove-100-tier-reward-key
• feat/remove-ws-pool
• feat/request-to-lower-hand
• feat/requests-notifications
• feat/restrict-signed-fetch
• feat/return-unrecognized-when-status-not-found
• feat/rewards-adapter
• feat/rpc-context-component
• feat/save-and-validate-max-ips-referral
• feat/send-marketing-email
• feat/send-more-info-in-friendship-notifications
• feat/send-notifications-with-retry
• feat/send-profile-info-on-upsert-and-friendship-updates
• feat/send-rewards-for-referral
• feat/set-member-role-endpoint
• feat/start-call-request
• feat/start-http-server-in-new-port
• feat/stream-connectivity-status
• feat/subscribe-to-private-voice-chat-updates
• feat/subscribe-to-worlds-events-in-nats
• feat/swag-irl-mail
• feat/thumbnails-retrieval
• feat/thumbnails-to-s3
• feat/thumbnails-validations
• feat/update-community
• feat/update-pm-settings-comms-gatekeeper
• feat/use-common-analytics-component
• feat/use-node-18-alpine-image
• feat/use-online-subscribers-for-community-status-updates
• feat/use-redis-for-content-validation-cache
• feat/validate-email
• feat/validate-name-ownership
• feat/validate-places-ownership
• feat/voice-status-communities-endpoint
• feat/when-using-only-member-of-sort-by-role
• fix/addresses-inverted-in-friendships-table
• fix/admin-restrictions-places-and-name
• fix/ai-compliance-dev-environment-race-condition
• fix/always-return-the-same-community-thumbnail-url
• fix/attach-transport-after-callbacks
• fix/avoid-rejectected-ips-to-finalize-process
• fix/avoid-spamming-connectivity-status-updates
• fix/aws-bucket-integration
• fix/block-user-on-conflict-was-failing
• fix/bucket-integration
• fix/bump-protocol-fixing-unblock-missing-props
• fix/change-get-credentials-body
• fix/check-bans-before-joining
• fix/communities-fetch
• fix/communities-requests-edge-cases
• fix/communities-ws-updates
• fix/community-creation
• fix/community-removed-ws-notification
• fix/community-rename-notification
• fix/connectivity-status-streaming
• fix/connectivity-status-updates
• fix/danglings-requests
• fix/date-number
• fix/deployment
• fix/do-not-show-private-chat-statuses
• fix/email-send-contents
• fix/env-mismatches
• fix/error-on-order-in-count-query
• fix/events-integration
• fix/events-integration-on-communities
• fix/expose-community-by-id-endpoint
• fix/expose-port-for-rpc-server
• fix/flaky-tests-due-to-ports-already-in-use
• fix/get-friends-duplicated-addresses
• fix/get-voice-chat-status
• fix/inconsistency-when-observing-total-connections
• fix/increment-auth-timeout
• fix/list-community-members
• fix/missing-column-in-select-for-sorting
• fix/missing-glibc-from-alpine
• fix/multiple-cleanup-calls-on-uws-transport
• fix/normalize-address-check-community-member-role
• fix/notification-key-should-be-action-id
• fix/notify-affected-member-when-leaving-a-community
• fix/notify-members-when-community-deleted-from-moderation
• fix/observable-duration-must-be-number
• fix/observe-active-connections-when-the-number-changes
• fix/peers-sync-was-stringifying-result
• fix/proper-codes-on-procedure-call-metrics
• fix/publish-to-sqs-using-raw-messages
• fix/race-condition-between-authenticating-user-and-following-messages
• fix/referral-update-only-when-tier-is-not-granted
• fix/renaming-community-notification
• fix/request-places-api-using-json-content-type
• fix/return-connection-url-as-credentials
• fix/run-integration-tests-sequentially
• fix/run-time
• fix/send-auth-token-when-creatings-credentials
• fix/send-reward-correct-destination
• fix/send-updates-to-correct-users
• fix/skip-parsed-friendship-requests-if-cant-be-parsed
• fix/skip-updates-if-required-profile-is-not-found
• fix/stream-connect-when-nats-broadcast-connect
• fix/syntax-error-on-query
• fix/update-node-version
• fix/update-private-voice-chat-protocol
• fix/use-lambdas-url
• fix/various-changes
• fix/voice-chat-status-not-null
• fix/was-using-ts-version-of-protocol
• fix/wrong-request
• fix/ws-pool-connections-tracking
• main
• refactor/avoid-breaking-grafana-through-incorrect-cardinality
• refactor/block-user
• refactor/community-logic-component
• refactor/componentize-friends-business-logic
• refactor/get-blocked-user
• refactor/get-blocking-status
• refactor/get-friendship-requests
• refactor/get-friendship-status
• refactor/get-mutual-friends
• refactor/get-profile-prop-or-default
• refactor/migrate-logic-updates-to-component
• refactor/move-redis-operations-to-proper-component
• refactor/move-rpc-service-creators-to-a-router
• refactor/move-rpc-service-creators-to-controllers-handlers
• refactor/rpc-services-to-different-files
• refactor/start-using-core-components
• refactor/store-profiles-only-relevant-props-in-redis
• refactor/unblock-user
• refactor/upsert-friendship
• refactor/use-lambdas-for-profiles-fetching
• refactor/use-new-gatekeeper-endpoint-to-get-all-cvcs
• test/integration-tests
• test/rpc-integration-tests

Build # 17660997262

Build Type

Pull #291

github

Committed by aleortega

Commit Message

fix: edge case

Pull Request Pull Request #291: fix: prevent unexpected privacy change on private communities when updating other fields

Run Details

1917 of 2253 branches covered (85.09%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4649 of 5089 relevant lines covered (91.35%)

60.75 hits per line