decentraland / builder
53%

DEFAULT BRANCH: master
Repo Added
Files 377
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 52.859% (-0.9%) from 53.733%
33800829456

push

github

web-flow 
feat: list collections through the newest off-chain marketplace (#3473)

* feat: list collections through the newest off-chain marketplace

Grants minter rights to the newest marketplace version deployed on the chain
rather than always V2, so testnet listings go through V3 while mainnet keeps
using V2 until V3 ships there. The authorization modal labels whichever
version was resolved.

isEnableForSaleOffchain now accepts any deployed version as the minter, not
just V1 or V2. Narrowing it to the current version would make every
collection listed through an older marketplace look unlisted.

The resolution deliberately mirrors decentraland-dapps' getTradeSignature and
has to stay in step with it: the marketplace granted minter rights is the one
that mints the item, so it must be the version the trade was signed against.

* fix: revoke every held marketplace version when disabling off-chain sale

enableSaleOffchain only revoked the newest version, so a collection holding
V2 minter rights kept them after the user turned off-chain sale off: listings
on that version stayed sellable, and isEnableForSaleOffchain - which accepts
any deployed version - still reported the collection as on sale.

Enabling still grants the newest version only, since the minter has to be the
contract the trade was signed against. Disabling now revokes every version
the collection actually holds, falling back to the newest when it holds none
so the contract never receives empty arrays.

* chore: pick up decentraland-dapps 29.7.1

29.7.1 is the first release where getTradeSignature signs against the newest
deployed marketplace rather than V2. Until now Builder granted minter rights to V3
on testnets while dapps still signed the trade against V2, so the authorized minter
was not the contract that settles and a primary listing reverted at mint.

Adds the cross-package regression test promised on #3472: the address Builder
authorizes has to equal the one dapps builds its EIP-712 domain f... (continued)

2627 of 6250 branches covered (42.03%)

Branch coverage included in aggregate %.

32 of 37 new or added lines in 4 files covered. (86.49%)

7911 of 13686 relevant lines covered (57.8%)

36.7 hits per line

Relevant lines Covered
13686 RELEVANT LINES 7911 COVERED LINES
36.7 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33800829456 master feat: list collections through the newest off-chain marketplace (#3473) * feat: list collections through the newest off-chain marketplace Grants minter rights to the newest marketplace version deployed on the chain rather than always V2, so test... push web-flow github
52.86
33647048493 master fix: fetch the third party on the collection detail page only after login (#3500) Gate the fetchThirdParty effect on the logged-in state so the authenticated GET /thirdParties/:id request is not fired before a wallet is connected, avoiding a spur... push web-flow github
53.73
33617099474 master Add safe external-link helpers and stop trusting server-managed collection fields on the client push cyaiox github
53.73
33004031989 master chore: bump decentraland-transactions to 3.1.1 (#3472) TradeService resolves a trade's contract by address through getContractName, which throws on an unknown one. The moment the backend records a trade against the V3 address, accept and cancel f... push web-flow github
53.52
33001220868 master fix(auth): upgrade decentraland-crypto-fetch to 3 (#3469) * fix(auth): upgrade decentraland-crypto-fetch to 3 Version 2 built the signed payload as `[method, path, timestamp, data].join(':').toLowerCase()`, folding the metadata along with everyt... push web-flow github
53.52
32993763347 master feat: add Copy URN option to collection item context menu (#3484) Co-authored-by: Rocío Mena <rociocmena@gmail.com> push web-flow github
53.52
32983844391 master fix: render ENS name tiles in the browser (#3483) The ENS list and detail pages loaded their tile from the marketplace server's /v1/ens/generate endpoint, which is being removed: it is unauthenticated and turns the width and height query params s... push web-flow github
53.53
32976403831 master fix: infinite render loop in the Intercom component (#3482) analyticsReadyCallback depended on intercomUserData and set a new state object on every invocation, so each render recreated the callback, re-ran the effect, and re-registered analytics.... push web-flow github
53.68
32972449175 master chore: bump decentraland-ui2 to ^3.22.0 and decentraland-dapps to ^29.7.0 (#3481) push web-flow github
53.68
32857981712 master feat: attribute shop announcement bar clicks from the builder (#3480) push web-flow github
53.67
See All Builds (8692)