decentraland / builder / 37777506526

58%

push

github

feat: notify creators about item listings cancelled by the marketplace contract upgrade (#3519)

* feat: notify creators about item listings cancelled by the marketplace contract upgrade

Pausing the older off-chain marketplace contracts and bumping their
signature index cancels every open item listing signed on them. Fetch
the creator's cancelled public item orders from marketplace-server
(signed GET /v1/cancelled-trades) and surface them:

- Collections list: banner with the total and each affected collection,
  linking to its detail page.
- Collection detail: notice listing the affected items with their
  previous price and a "Put for sale again" action that opens the
  existing put-for-sale flow.

Both are dismissible and gated by the cancelled-item-orders-notice flag.
Re-listing an item drops its entry.

* fix: load every page of the creator's cancelled item listings

Only the first 100 cancelled trades were fetched and filtered to item
listings client side, so creators with many NFT listings or bids lost
item listings and got wrong per-collection counts.

- Request only public_item_order and page through the whole set
  (first=100, skip, up to 3 pages at a time), deduping by id. A failed
  page keeps what loaded and flags the list as incomplete.
- Collections banner: largest collections first, top 5 plus a toggle
  to show the rest in a scrollable list.
- Collection notice: re-listable items first, first 5 plus a toggle to
  show all in a scrollable list.

* refactor: name the cancelled item orders module after its domain

The builder only handles cancelled item orders, so the module, state key,
reducer and saga follow the CancelledItemOrder naming. The API client keeps
the marketplace's cancelled trades naming.

* fix: keep loaded cancelled item orders when a later request fails

Pages are fetched one after the other. A failure after the first page keeps
what loaded and flags it as incomplete, and a failed collections request no
longer drops th... (continued)

2705 of 5808 branches covered (46.57%)

Branch coverage included in aggregate %.

186 of 188 new or added lines in 15 files covered. (98.94%)

7819 of 12480 relevant lines covered (62.65%)

49.25 hits per line