dblock / strava-ruby-client

100%

master: 100%

LAST BUILD ON BRANCH appraisals-json

branch: appraisals-json

CHANGE BRANCH

x

Reset

• appraisals-json
• dblock/add-coveralls
• dblock/coveralls-github-token
• dblock/revert-api-v3-url
• fix-json-3-compat
• master
• remove-deprecated-club-endpoints
• reorder-club-functions
• update-releasing-docs
• v3.1.0

Build # 34707207645

Build Type

Pull #114

github

Committed by dblock

Commit Message

Add Appraisals to reproduce and track json 3.x incompatibility

Adds an Appraisal-based test matrix (json-2, json-3) run in CI so the
existing spec suite is exercised against both the currently supported
json < 3.0 and json >= 3.0, reproducing the Faraday::ParsingError /
ArgumentError described in #113 whenever json 3.x is resolved.

- Add 'appraisal' gem and an Appraisals file defining 'json-2' and
  'json-3' appraisals.
- Move rubocop, rubocop-rake, and rubocop-rspec out of the main Gemfile
  into their own gemfiles/rubocop.gemfile, since rubocop < 1.90 pins
  json ~> 2.3, which otherwise made it impossible to resolve a Gemfile
  that also depends on json ~> 3.0.
- Update the Rakefile default task and .github/workflows/rubocop.yml to
  use gemfiles/rubocop.gemfile via BUNDLE_GEMFILE.
- Add a CI job in .github/workflows/test.yml that runs 'rake spec'
  against each appraisal gemfile; the json-3 job is currently expected
  to fail, tracking when the incompatibility is resolved.
- Exclude generated gemfiles/*.gemfile from rubocop and
  gemfiles/*.gemfile.lock from git.
- Document the new workflow in CONTRIBUTING.md and CHANGELOG.md.

Verified locally: the existing oauth/api/webhooks specs pass under
gemfiles/json_2.gemfile (0 failures) and fail under
gemfiles/json_3.gemfile with the exact reported error, reproducing
https://github.com/dblock/strava-ruby-client/issues/113.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Pull Request Pull Request #114: Add Appraisals to test against multiple json gem versions

Coverage Stats

3808 of 3815 relevant lines covered (99.82%)

226.46 hits per line