dblock / strava-ruby-client / 34707207645
100%
master: 100%

LAST BUILD BRANCH: fix-json-3-compat
DEFAULT BRANCH: master
Ran
Jobs 8
Files 163
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 99.817%. Remained the same
34707207645

Pull #114

github

dblock 
Add Appraisals to reproduce and track json 3.x incompatibility

Adds an Appraisal-based test matrix (json-2, json-3) run in CI so the
existing spec suite is exercised against both the currently supported
json < 3.0 and json >= 3.0, reproducing the Faraday::ParsingError /
ArgumentError described in #113 whenever json 3.x is resolved.

- Add 'appraisal' gem and an Appraisals file defining 'json-2' and
  'json-3' appraisals.
- Move rubocop, rubocop-rake, and rubocop-rspec out of the main Gemfile
  into their own gemfiles/rubocop.gemfile, since rubocop < 1.90 pins
  json ~> 2.3, which otherwise made it impossible to resolve a Gemfile
  that also depends on json ~> 3.0.
- Update the Rakefile default task and .github/workflows/rubocop.yml to
  use gemfiles/rubocop.gemfile via BUNDLE_GEMFILE.
- Add a CI job in .github/workflows/test.yml that runs 'rake spec'
  against each appraisal gemfile; the json-3 job is currently expected
  to fail, tracking when the incompatibility is resolved.
- Exclude generated gemfiles/*.gemfile from rubocop and
  gemfiles/*.gemfile.lock from git.
- Document the new workflow in CONTRIBUTING.md and CHANGELOG.md.

Verified locally: the existing oauth/api/webhooks specs pass under
gemfiles/json_2.gemfile (0 failures) and fail under
gemfiles/json_3.gemfile with the exact reported error, reproducing
https://github.com/dblock/strava-ruby-client/issues/113.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pull Request #114: Add Appraisals to test against multiple json gem versions

3808 of 3815 relevant lines covered (99.82%)

226.46 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4.0 - 34707207645.1 101
100.0
 GitHub Action Run
2 3.4 - 34707207645.2 101
100.0
 GitHub Action Run
3 jruby-10 - 34707207645.3 101
99.62
 GitHub Action Run
4 jruby-9.4 - 34707207645.4 163
99.53
 GitHub Action Run
5 3.2 - 34707207645.5 101
100.0
 GitHub Action Run
6 3.3 - 34707207645.6 101
100.0
 GitHub Action Run
7 3.1 - 34707207645.7 163
99.82
 GitHub Action Run
8 3.4-gemfiles/json_2.gemfile - 34707207645.8 101
100.0
 GitHub Action Run
Source Files on build 34707207645