davidbyttow / govips

72%

master: 39%

LAST BUILD ON BRANCH fix/keepalive-cgo

branch: fix/keepalive-cgo

CHANGE BRANCH

x

Reset

• fix/keepalive-cgo
• 0.4.4
• c_format
• david/fix-tests
• david/minor-cleanups
• david/revert-obsoletion
• davidbyttow/fix-gnu-warnings
• dependabot/go_modules/golang.org/x/image-0.10.0
• dependabot/go_modules/golang.org/x/image-0.18.0
• dependabot/go_modules/golang.org/x/image-0.5.0
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.23.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/npm_and_yarn/examples/tiff/minimist-1.2.6
• dependabot/npm_and_yarn/examples/tiff/semver-7.5.3
• dependabot/npm_and_yarn/examples/tiff/semver-7.5.4
• dependabot/npm_and_yarn/examples/tiff/sharp-0.30.5
• dependabot/npm_and_yarn/examples/tiff/sharp-0.32.6
• dependabot/npm_and_yarn/examples/tiff/simple-get-4.0.1
• devops-update
• devops-update2
• export_params
• export_tiff
• fix-#144
• fix/247-test-reorg
• fix/275-cmyk-icc-profile
• fix/287-grey-gradient
• fix/306-transparent-canvas
• fix/350-animated-resize-rounding
• fix/359-gif-quality-docs
• fix/381-loop-metadata
• fix/457-jxl-detection
• fix/463-tiff-tile-zero
• fix/489-480-image-interop
• fix/c-code-bugs
• fix/ci-go-version
• fix/memory-leaks
• fix/minor-cleanup
• fix/quick-wins
• fix/readme-deprecated-api
• fix/remove-incorrect-defers
• fix/replace-deprecated-getpageheight
• fix/startup-error-handling
• fix/test-panics-to-fatal
• fix_21
• fix_embed_alpha
• gobject_save
• goldentests
• images
• import_params
• importparams
• jake/webp-shrink-on-load
• jammy-ref
• logging
• mac_version
• master
• merge-files
• newgoldens
• reduce-handwritten-c-bridge-code
• refresh
• refs/tags/2.10.0
• refs/tags/v2.1.0
• refs/tags/v2.10.0
• refs/tags/v2.11.0
• refs/tags/v2.12.0
• refs/tags/v2.13.0
• refs/tags/v2.14.0
• refs/tags/v2.15.0
• refs/tags/v2.17.0
• refs/tags/v2.2.0
• refs/tags/v2.3.0
• refs/tags/v2.3.1
• refs/tags/v2.4.0
• refs/tags/v2.5.0
• refs/tags/v2.6.0
• refs/tags/v2.7.0
• refs/tags/v2.8.0
• refs/tags/v2.8.1
• refs/tags/v2.9.0
• revert-merge
• test/tier1-coverage
• toni-test
• toni-testing
• tonimelisma-doubleunref
• tonimelisma-patch-1
• update
• v2.0.0
• v2.0.1
• v2.0.2
• vipsgen
• worktree-fix-avis-detection

Build # 22505189670

Build Type

Pull #494

github

Committed by davidbyttow

Commit Message

Add runtime.KeepAlive to prevent GC finalization during CGo calls

ImageRef methods that pass r.image to CGo functions without
referencing r afterward are vulnerable to a use-after-free: the GC
can finalize the ImageRef (via runtime.SetFinalizer) while the CGo
call is still executing on the underlying C.VipsImage pointer.

This manifests as flaky segfaults, e.g. TestImageRef_FindTrim_White
crashing with "instance of invalid non-instantiatable type" from GLib.

Fix: add defer runtime.KeepAlive(r) to all 33 vulnerable methods,
ensuring the receiver stays alive for the duration of each CGo call.
This is the standard Go idiom (used in os.File, net.Conn, etc.).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Pull Request Pull Request #494: Fix GC use-after-free in ImageRef CGo calls

Coverage Stats

24 of 33 new or added lines in 1 file covered. (72.73%)

2238 of 3119 relevant lines covered (71.75%)

0.76 hits per line