darnir / wget2

66%

master: 67%

LAST BUILD ON BRANCH fix-test-memleak

branch: fix-test-memleak

CHANGE BRANCH

x

Reset

• fix-test-memleak
• clang_attrib
• cov-fixes
• coveralls-test
• define-to-enum
• expand_filenames
• fix-parse-header
• fix-progress-http2
• header-option
• master
• new-travis
• no-config
• progress-fix
• progress-tests
• pure-functions
• refactor-prog
• refactor-progressbar
• timestamping
• tmp-fix-copyrights
• tmp-update-configure
• travis-coveralls
• travis-msan
• travis-test
• wgetapi

Build # 154

Build Type

push

travis-ci

Committed by darnir

Commit Message

Fix memory leak in test-metalink

This memory leak was particularly interesting. Valgrind did *NOT* report
the leak at all while GCC's Memory Sanitizer did, leading me to believe
that this is a bug in the memory sanitizer. However, the memory leak
does indeed exist and Valgrind misses it.

The leak happens because the url->body is always statically allocated.
_If_ we replace the {{port}} in the body, the new string is dynamically
allocated and stored in the struct. However, if the user stores a
dynamically allocated memory in the struct, then we replace it during
wget_test_start_server leaking that memory.

* tests/test-metalink.c: Explicitly deallocate dynamically allocated
memory

Run Details

5904 of 8955 relevant lines covered (65.93%)

3338.98 hits per line