danieldreier / autosign

82%

master: 95%

LAST BUILD ON BRANCH unsafe_yaml

branch: unsafe_yaml

CHANGE BRANCH

x

Reset

• unsafe_yaml
• 1.0-release
• add_license
• bare_token
• base_class
• bump_version_down
• dependabot/bundler/ffi-1.9.25
• dependabot/bundler/rake-tw-13
• dependabot/bundler/rexml-3.2.5
• dependabot/bundler/yard-0.9.20
• fix_config_path
• less_helpful
• master
• no193
• switch_to_yaml_config
• update_gems
• v0.0.10
• v0.0.11
• v0.0.3
• v0.0.4
• v0.0.5
• v0.0.6
• v0.0.7
• v0.0.8
• v0.0.9
• v0.1.1
• v0.1.2
• v0.1.3
• v0.1.4
• v1.0.0
• v1.0.1
• validator
• validator_list

Build # 66

Build Type

push

travis-ci

Committed by danieldreier

Commit Message

Remove safe_yaml gem

Remove dependencies on the safe_yaml gem because it has adverse
interactions with JVM puppetserver.

When safe_yaml is loaded into JVM puppetserver, it causes YAML fact
caches to be loaded as hashes rather than as serialized ruby objects,
which causes compiles to fail with an error about trusted facts that
reads:

Error 400 on SERVER: Attempt to assign to a reserved variable name:
'trusted' on node

There isn't a strong need for safe_yaml in autosign, because it's only
used to ensure safe loading of the configuration file. In principle,
somebody could now modify the config file to be a serialized ruby
object, but that person would probably already have sufficient access to
cause problems regardless.

Run Details

468 of 574 relevant lines covered (81.53%)

30.32 hits per line