curationexperts / laevigata

97%

main: 97%

LAST BUILD ON BRANCH fix_redis_namespace_deprecations

branch: fix_redis_namespace_deprecations

CHANGE BRANCH

x

Reset

• fix_redis_namespace_deprecations
• cache_junit_reporter
• dependabot/npm_and_yarn/axios-0.30.0
• dependabot/npm_and_yarn/babel/helpers-7.27.0
• dependabot/npm_and_yarn/babel/runtime-7.27.0
• dependabot/npm_and_yarn/brace-expansion-1.1.12
• dependabot/npm_and_yarn/cipher-base-1.0.6
• dependabot/npm_and_yarn/elliptic-6.6.1
• dependabot/npm_and_yarn/nanoid-3.3.8
• dependabot/npm_and_yarn/pbkdf2-3.1.3
• dependabot/npm_and_yarn/sha.js-2.4.12
• embargo_notifications
• fix_flaky_test
• fix_grad_service
• fix_redis_current
• grad_dates
• homepage-nursing
• main
• speedier_tests
• spelling-misteak
• test_ci

Build # 90fcbe81-971e-4d3f-858a-e0ec8e932fa6

Build Type

Pull #2468

circleci

Committed by mark-dce

Commit Message

Fix redlock deprecation warnings

**ISSUE**
After the `Redis.current` fix, we are now seeing significant numbers
of deprecations warnings like:
```
Passing 'call' command to redis as is; blind passthrough has been
  deprecated and will be removed in redis-namespace 2.0
  (at /Users/mark/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/
   redlock-2.0.6/lib/redlock/client.rb:214:in `block (2 levels) in unlock')
```

**DIAGNOSIS**
We were passing a RedisNamespace object to Redlock instead of a
plain Redis connection specifier. RedisNamespace was complaining
any time an admin (not-namespace-able) command was received.

**RESOLUTION**
Pass a Redis URI to RedLock instead of a RedisNamespace object.

Pull Request Pull Request #2468: Fix redlock deprecation warnings

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

122 existing lines in 26 files now uncovered.

2837 of 2912 relevant lines covered (97.42%)

52.1 hits per line