codozor / fwkeeper

47%

main: 45%

Pull #7

github

refactor: Remove unnecessary kubernetes client adapter layer

Eliminate 9 adapter types that added unnecessary indirection to the codebase.
The adapters (kubernetesClientAdapter, coreV1Adapter, podAdapter, serviceAdapter,
appsV1Adapter, deploymentAdapter, statefulSetAdapter, daemonSetAdapter) were
thin wrappers that simply passed through to kubernetes.Interface without adding value.

Changes:
- Removed 98 lines of adapter boilerplate from internal/app/runner.go
- Simplified locator interfaces to use kubernetes.Interface directly
- Updated pod.go, service.go, and selector_based_locator.go type signatures
- Refactored locator_test.go to use standard kubernetes/fake.Clientset
- Deleted mock_kubernetes.go (243 lines, replaced by fake.Clientset)
- Fixed TestRunnerConfigChangeDetection to use fake client for validation

Benefits:
- 30% reduction in runner.go code
- Improved maintainability by removing abstraction layers
- Aligns with Kubernetes ecosystem testing standards (fake.Clientset)
- Single source of truth: kubernetes.Interface
- Zero test regressions: 78/78 tests passing

1 of 3 new or added lines in 1 file covered. (33.33%)

369 of 779 relevant lines covered (47.37%)

0.53 hits per line