codozor / fwkeeper / 19598121198

47%

main: 45%

Build Type

Pull #7

github

Committed by SebastienLaurent-CF

Commit Message

✅ test: Add Phase 2 test coverage for locator implementations

Implement comprehensive test coverage for all locator implementations (pod, service, deployment, statefulset, daemonset) with mocked Kubernetes client. Refactor locator interfaces for better testability.

Architecture Changes:
- Create custom KubernetesClient interface hierarchy for cleaner abstraction:
  * KubernetesClient (CoreV1() + AppsV1())
  * CoreV1Client (Pods() + Services())
  * PodClient (Get() + List())
  * ServiceClient (Get())
  * AppsV1Client (Deployments() + StatefulSets() + DaemonSets())
  * ResourceClient (Get() returning interface{})
- Implement MockKubernetesClient supporting all resource types with helper methods
- Add adapters in runner.go to convert real kubernetes.Interface to custom interfaces
- Refactor locator implementations to use custom interfaces instead of kubernetes.Interface

Test Coverage (Phase 2):
- Pod locator (6 tests):
  * Pod found and running
  * Pod not found error handling
  * Pod not running states (pending, failed, succeeded, unknown)
- Service locator (3 tests):
  * Service found with running backing pod
  * Service not found error handling
  * No running pods for service error
- Resource locators (3 tests):
  * Deployment, StatefulSet, DaemonSet selector-based discovery
- Locator builder (16 tests):
  * Pod format routing (direct name)
  * Service formats: svc/, service/, services/
  * Deployment formats: dep/, deployment/, deployments/
  * StatefulSet formats: sts/, statefulset/, statefulsets/
  * DaemonSet formats: ds/, daemonset/, daemonsets/
  * Invalid format and too many slashes error handling

Files Added:
- internal/locator/mock_kubernetes.go - Complete mock client implementation (240+ lines)
- internal/locator/locator_test.go - Comprehensive locator tests (350+ lines)

Files Modified:
- internal/locator/locator.go - Define custom interfaces, refactor BuildLocator
- internal/locator/pod.go - Use KubernetesClient interface
- internal/lo... (continued)

Pull Request Pull Request #7: ✅ test: Add Phase 1 test coverage for critical paths

Run Details

153 of 215 new or added lines in 6 files covered. (71.16%)

119 existing lines in 4 files now uncovered.

319 of 978 relevant lines covered (32.62%)

0.36 hits per line