codenotary / immudb

85%

master: 85%

LAST BUILD ON BRANCH fix/issue-2100-sql-panics

branch: fix/issue-2100-sql-panics

CHANGE BRANCH

x

Reset

• fix/issue-2100-sql-panics
• chore/build-updates
• chore/deps-trivy-x-bumps
• chore/test-followups
• ci-regex-fix
• docker-init-db
• fargate
• feat/auditlog
• feat/coalesce
• feat/s3performance
• feature/between-and
• feature/constant-selection-query
• feature/discard-precommitted-txs
• feature/extract-from-timestamp
• feature/individual-col-primary-key
• feature/left-join
• feature/pgsql-catalog
• fix/2082-scan-latest
• fix/cas-notarize
• fix/display-actual-config-path-on-startup
• fix/empty-tree-flush
• fix/empty-tree-flush-file
• fix/index_metrix
• fix/swagger-test-go122-mux
• gh_action_update
• issue-2028
• master
• moshix-patch-8
• parallelvcn
• patch-1
• refs/tags/v1.1.0
• refs/tags/v1.10.0
• refs/tags/v1.11.0
• refs/tags/v1.11.0-RC2
• refs/tags/v1.2.0
• refs/tags/v1.2.0-RC1
• refs/tags/v1.2.1
• refs/tags/v1.2.2
• refs/tags/v1.2.3
• refs/tags/v1.2.3-RC1
• refs/tags/v1.2.4
• refs/tags/v1.2.4-RC1
• refs/tags/v1.3.0
• refs/tags/v1.3.0-RC1
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.3.2-RC1
• refs/tags/v1.4.0
• refs/tags/v1.4.0-RC1
• refs/tags/v1.4.0-RC2
• refs/tags/v1.4.1
• refs/tags/v1.4.1-RC1
• refs/tags/v1.5.0
• refs/tags/v1.5.0-RC1
• refs/tags/v1.9.0-RC1
• refs/tags/v1.9.0-RC2
• refs/tags/v1.9.3
• refs/tags/v1.9.4
• refs/tags/v1.9.5
• refs/tags/v1.9.6
• refs/tags/v1.9.7
• refs/tags/v1.9DOM
• refs/tags/v1.9DOM.0
• refs/tags/v1.9DOM.1
• refs/tags/v1.9DOM.1-RC1
• refs/tags/v1.9DOM.2
• refs/tags/v1.9DOM.2-RC1
• refs/tags/v2.0.0-RC1
• release/v1.10.0
• release/v1.2.4
• release/v1.2.4-RC1
• release/v1.3.0
• release/v1.3.0-RC1
• release/v1.3.1
• release/v1.3.2
• release/v1.3.2-RC1
• release/v1.4.0
• release/v1.4.0-RC1
• release/v1.4.0-RC2
• release/v1.4.1
• release/v1.4.1-RC1
• release/v1.5.0
• release/v1.5.0-RC1
• release/v1.9.0-RC1
• release/v1.9.0-RC2
• release/v1.9.3
• release/v1.9.4
• release/v1.9.5
• release/v1.9.6
• release/v1.9.7
• release/v1.9DOM
• release/v1.9DOM.0
• release/v1.9DOM.1
• release/v1.9DOM.1-RC1
• release/v1.9DOM.2
• release/v1.9DOM.2-RC1
• release/v2.0.0-RC1
• update-copyright-notice
• v2-prerelease

Build # 28179252400

Build Type

Pull #2101

gh-ci

Committed by vchaindz

Commit Message

fix(sql): prevent two SQL engine panics introduced in 1.11.0 (#2100)

Two server-crashing panics were reachable from ordinary, valid client
traffic after upgrading to 1.11.0:

1. nil pointer dereference in the disk-spill sort path. The 1.11.0
   projection-pushdown optimization leaves Row.ValuesByPosition[i] nil for
   columns a query does not reference, assuming those slots are never
   accessed. The new file-sort encode path (fileSorter.encodeRow) walked
   every position and called v.Type() on the nil slots, crashing on large
   ORDER BY ... OFFSET result sets that spill to a temp file. encodeRow is
   now a *fileSorter method that substitutes a typed NULL
   (&NullValue{t: s.colTypes[i]}) for nil slots, which round-trips through
   the temp file as SQL NULL.

2. index out of range [0] in db.SQLQuery. Since 1.11.0 the grammar accepts
   empty/comment-only input and ParseSQL returns an empty statement slice
   with no error, so empty probe queries panicked on stmts[0]. Added a
   len(stmts) == 0 guard returning ErrExpectingDQLStmt, matching the
   guard db.SQLExec already uses.

Adds regression tests reproducing both panics.

Pull Request Pull Request #2101: fix(sql): prevent two SQL engine panics introduced in 1.11.0 (#2100)

Coverage Stats

13 of 13 new or added lines in 2 files covered. (100.0%)

11 existing lines in 4 files now uncovered.

45223 of 53221 relevant lines covered (84.97%)

126799.02 hits per line