codenotary / immudb / 28179252400

85%

master: 85%

Build Type

Pull #2101

gh-ci

Committed by vchaindz

Commit Message

fix(sql): prevent two SQL engine panics introduced in 1.11.0 (#2100)

Two server-crashing panics were reachable from ordinary, valid client
traffic after upgrading to 1.11.0:

1. nil pointer dereference in the disk-spill sort path. The 1.11.0
   projection-pushdown optimization leaves Row.ValuesByPosition[i] nil for
   columns a query does not reference, assuming those slots are never
   accessed. The new file-sort encode path (fileSorter.encodeRow) walked
   every position and called v.Type() on the nil slots, crashing on large
   ORDER BY ... OFFSET result sets that spill to a temp file. encodeRow is
   now a *fileSorter method that substitutes a typed NULL
   (&NullValue{t: s.colTypes[i]}) for nil slots, which round-trips through
   the temp file as SQL NULL.

2. index out of range [0] in db.SQLQuery. Since 1.11.0 the grammar accepts
   empty/comment-only input and ParseSQL returns an empty statement slice
   with no error, so empty probe queries panicked on stmts[0]. Added a
   len(stmts) == 0 guard returning ErrExpectingDQLStmt, matching the
   guard db.SQLExec already uses.

Adds regression tests reproducing both panics.

Pull Request Pull Request #2101: fix(sql): prevent two SQL engine panics introduced in 1.11.0 (#2100)

Coverage Stats

13 of 13 new or added lines in 2 files covered. (100.0%)

11 existing lines in 4 files now uncovered.

45223 of 53221 relevant lines covered (84.97%)

126799.02 hits per line