codenotary / immudb
85%
master: 85%

LAST BUILD BRANCH: dependabot/go_modules/github.com/prometheus/common-0.70.1
DEFAULT BRANCH: master
Repo Added
Files 311
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH chore/fix-coverage-ci
branch: chore/fix-coverage-ci
CHANGE BRANCH
x

coverage: 84.975% (+0.02%) from 84.96%
30472424263

Pull #2115

gh-ci

vchaindz 
ci(coverage): stop swallowing test failures, and drop the unused codecov config

The Coverage job ended its test run with `|| true`, which defeated the
`set -o pipefail` on the line directly above it. A failing or panicking package
was discarded, the partial coverage.txt was uploaded regardless, and the job
reported success. A real test failure therefore surfaced only as a slightly
lower coverage percentage on coveralls — indistinguishable from ordinary
measurement noise, and invisible in the job status.

Capture go-acc's exit status instead. The profile is still uploaded, so a failed
run does not also become a reporting blind spot, and the job then fails with an
explicit ::error:: naming the exit code. In push.yml the check is placed after
`docker rm -f minio` so the container is torn down even when the run failed.

Also removes codecov.yml. No workflow references codecov — coverage goes to
coveralls via goveralls in pull.yml and push.yml — so the file only misled
anyone editing it expecting an effect.

Verified: both workflows still parse as YAML (5 and 10 jobs); the modified run
blocks pass `bash -n`; no `${{ }}` interpolation was introduced; and the
exit-status logic was exercised directly — pass exits 0, failure exits non-zero
while still performing the upload.

Not addressed here, deliberately: coverage is measured nondeterministically
(consecutive master builds drift by ~0.006% with no coverage-relevant change),
and the external coverage/coveralls status reports failure even when coverage
increases. That status is set from the coveralls.io project settings, not from
this repository.
Pull Request #2115: ci(coverage): stop swallowing test failures, and drop the unused codecov config

45228 of 53225 relevant lines covered (84.98%)

124555.17 hits per line

Relevant lines Covered
53225 RELEVANT LINES 45228 COVERED LINES
124555.17 HITS PER LINE
Source Files on chore/fix-coverage-ci

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30472424263 chore/fix-coverage-ci ci(coverage): stop swallowing test failures, and drop the unused codecov config The Coverage job ended its test run with `|| true`, which defeated the `set -o pipefail` on the line directly above it. A failing or panicking package was discarded, ... Pull #2115 vchaindz gh-ci
84.98
See All Builds (4113)