codeforamerica / ohana-api

98%

master: 99%

LAST BUILD ON BRANCH wad-without-credentials

branch: wad-without-credentials

CHANGE BRANCH

x

Reset

• wad-without-credentials
• 10-user-agent
• 104-search-for-many-languages
• 164-fix-devise-bug
• 185-org-autocomplete
• 187-admin-languages
• 188-highlight-error-fields
• 200-remove-required-attribute
• 238-update-readme
• 25-api-keys
• 304-csv-export
• 308-add-new-program-button
• 313-copy-service
• 326-zip-csv-files
• 332-improve-import-errors
• 336-import-fixes
• 361-csv-memory
• 41-enable-ssl
• 69-create-app-link
• add-additional-fields
• add-admin-field-to-location
• add-codeclimate-config
• add-contacts-to-org
• add-contacts-to-service
• add-devise-paranoid
• add-docker-support
• add-gitattributes
• add-interpretation-services
• add-number_type-to-phones
• add-phones-to-org
• add-phones-to-service
• add-profiling-gems
• add-programs
• add-schedules
• add-sms-to-phone-number-type
• added_fields
• admin-interface
• admin-subdomain
• automatically-set-super-admin
• bootstrap-tweaks
• cache-gems-for-travis
• category-assignment-via-CSV
• csv-import
• data-merge
• disable-email-sending-during-db-seed
• disable-state-validation-for-non-us
• elasticsearch
• expose-weekday-as-integer
• fix-csv-import-script
• fix-dashboard-spec
• fix-devise-issues
• fix-docker
• fix-flickering-search-spec
• fix-heroku-db-setup
• fix-label-for-categories
• fix-ranking-issue
• fix-readme
• fix-rubocop-offenses
• fix-scss-offenses
• full-text-search-for-org-name
• holiday-schedules
• holiday-schedules-admin
• hound-config
• inactive-services
• installation-docs
• latlon
• master
• mb-protected-attributes
• mb-update-factory-bot
• mb-update-gems
• nearby
• only-validate-presence-of-state-for-us-and-ca
• optimize-admin-decorator
• order-categories
• pg-search
• postgres
• prevent-puma-connection-leakage
• readme-updates
• refactor-search
• refactor-validators
• remove-grape
• remove-redis
• remove-short-description-validations-137
• remove-unused-code
• remove-unused-http-headers
• rename-fields
• replace-location-emails-with-email
• replace-location-urls-with-website
• replace-mandrill-with-sendgrid
• replace-pg-search
• search-keyword-service-area
• search-multiple-categories
• select2-for-service-areas
• service-area-filter
• show-version-number-in-admin-interface
• snyk-fix-80ad56c6
• taxonomy-import
• test
• tweak-install-postgresql-words
• update-README
• update-bootstrap-sass
• update-caching
• update-dev-gems
• update-devise
• update-gems
• update-gems-with-bummr
• update-nearby-serializer
• update-nokogiri
• update-pundit
• update-rails
• update-readme
• update-required-fields
• update-root-endpoint
• update-rubocop
• update-ruby
• update-ruby-and-bummr
• update-sample-csvs
• update-services
• update-spec-setup
• update-status-controller
• update-uglifier
• updates-seed-user-comments
• updates-test-data
• updates-test-data-infobox
• upgrade-bootstrap
• upgrade-rspec
• upgrade-swagger
• use-select2-tags-for-service-keywords
• v0.3.1.0
• v1.0
• v1.1.0
• v1.2.0
• v2.0.0
• v3.0.0
• v3.1.0

Build # 519

Build Type

push

travis-ci

Committed by monfresh

Commit Message

Download gems from S3 without authorization.

By default, the `bin/wad` script sets an Authorization header using S3
credentials for both read and write operations. The problem is that pull
requests from forks can't use secure credentials on Travis, so all Travis
runs from external PRs will fail.

What gets stored on S3 is just a zipped up tarball of all the gems,
so it's perfectly safe to allow anyone to download the files from S3.
This commit modifies the script so that it only sets the Authorization
header during a write operation. On the S3 side, a policy was added to
the bucket to allow anonymous downloads:
http://docs.aws.amazon.com/AmazonS3/latest/dev/example-bucket-policies.html

Run Details

880 of 895 relevant lines covered (98.32%)

53.59 hits per line