codeforamerica / ohana-api
99%
master: 99%

LAST BUILD BRANCH: mb-update-factory-bot
DEFAULT BRANCH: master
Repo Added
Files 122
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 336-import-fixes
branch: 336-import-fixes
CHANGE BRANCH
x

994

push

travis-ci

monfresh 
Fix various issues with import script.

- Improve logic that determines whether or not a location needs to be geocoded. In addition, the location importer now checks to see if an address already exists for the location. If so, it updates that same address instead of assigning address attributes, which, unbeknown to me, actually destroyed the existing address and created a new one. The side effect of destroying the address is that it triggered the `reset_location_coordinates` callback, which in turn triggered the geocoding since the location no longer had coordinates.

- Invalid entries no longer prevent the entire CSV file from being saved to the database. Now, valid entries get saved, and error messages are displayed for invalid entries.

- If a CSV file doesn't have sequential IDs, the database will now save the entry with the same ID as in the CSV file. Previously, the database would assign sequential IDs, which would cause mismatches between CSV files that refer to a particular foreign key.

- Added a conditional for the `touch_locations` callback in organization.rb to improve performance during initial import of organizations.

- The console output that lets you know which file is being imported has been moved out of the rake task and into the EntityImporter. That way, if a file is skipped (because it's not required and is missing or empty, for example), then the console won't say that it is being imported.

Closes #336.

1673 of 1683 relevant lines covered (99.41%)

68.86 hits per line

Relevant lines Covered
1683 RELEVANT LINES 1673 COVERED LINES
68.86 HITS PER LINE
Source Files on 336-import-fixes
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
994 336-import-fixes Fix various issues with import script. - Improve logic that determines whether or not a location needs to be geocoded. In addition, the location importer now checks to see if an address already exists for the location. If so, it updates that same... push monfresh travis-ci pending completion  
993 336-import-fixes Fix various issues with import script. - Improve logic that determines whether or not a location needs to be geocoded. In addition, the location importer now checks to see if an address already exists for the location. If so, it updates that same... push monfresh travis-ci pending completion  
See All Builds (1061)