cloudmarker / cloudmarker

78%

master: 84%

LAST BUILD ON BRANCH renameparams

branch: renameparams

CHANGE BRANCH

x

Reset

• renameparams
• 0.1.0
• alertdocs
• apidocindent
• audit-version
• auditemails
• azcloud
• azstorage
• azurecloud
• azurecloud-exception
• azvm_record_type
• azwebapp
• badges
• baseconfig
• bracket
• buckets
• build-matrix
• changelog
• clioptions
• clouderror
• common-plugins-config
• consistency
• copy-ext
• copyext
• cov_clean
• dependabot/pip/cryptography-3.3.2
• dependabot/pip/httplib2-0.18.0
• dependabot/pip/httplib2-0.19.0
• dependabot/pip/pyyaml-5.4
• dependabot/pip/rsa-4.7
• dependabot/pip/urllib3-1.26.5
• dist
• docfixes
• doctest-fix
• email_debug_param_from_config
• emailbody
• emaildocs
• empty-port
• esstore
• firewalleventtest
• firewallnorm
• firewallruleevent
• fix-esstore-done
• fix-unused-input-queue
• fix_cloud_worker
• fixbuild
• fixcoverage
• fixindent
• freeze
• gcpcloudlogs
• gcpcloudtest
• iam_policy
• ignore-virtual-machines
• ioworkers
• key_file_name_fix
• lint
• load_yaml_safely
• log
• logfixes
• logger-defaults
• logging-levels
• master
• maxrecs
• mock-records
• mockplugins
• mongodbdefaults
• mongodbfix
• mongodbtests
• multiprocessing
• pluginframework
• pluginloader
• readable-version
• readme
• remove-email-config
• removefirewallevent
• rename_logger
• requirements
• rest
• reuse-mock
• rm-venv
• slackalert
• smtpssl
• sphinx
• sphinx-rst-update
• splunkfixes
• splunkhecstore_docs
• splunkhectokentest
• splunkstore
• sub_id_rename
• tests
• travis
• userconfig
• userdoc
• userecordterm
• verdev
• webapp
• worker-com-fields
• worker-error-handling
• workerlogs

Build # 304

Build Type

Pull #45

travis-ci-com

Committed by web-flow

Commit Message

Upgrade setuptools for Travis CI Python 3.4 builds

A build failure occurs in Travis CI builds for Python 3.4 since the
release of `isort 4.3.9`. The build failure occurs due to the following
combination of different factors:

 1. The latest version of `isort` at this time is `isort 4.3.9` which
    was released very recently on Feb 26, 2019.

 2. The `isort 4.3.9` package brings back (perhaps inadvertently) a
    conditional dependency on the `futures` package:

        futures; python_version < "3.2"

 3. When our project's dependencies are installed, `isort 4.3.9` gets
    installed but the `futures` package is ignored because the
    conditional dependency is not satisfied for Python versons 3.4 and
    above. This is correct behaviour.

 4. But during installation, the old version of `setuptools`, i.e.,
    `setuptools 35.0.2`, does not record the conditional dependency in
    the installed `METADATA` file of `isort`. The dependency is recorded
    as an unconditional dependency:

        Requires-Dist: futures

    This is incorrect behaviour. If the dependency were correctly
    recorded as a conditional dependency in the `METADATA` file, it would
    have looked like this:

        Requires-Dist: futures; python_version < "3.2"

    This dependency is correctly recorded in the `METADATA` file by
    `setuptools 36.2.0` and later versions.

 5. Pylama loads `isort` via `pkg_resources`. See `entry.load()()` call
    in `pylama/lint/extensions.py` for this call. This is a call into
    the `pkg_resources` package (part of `setuptools`).

 6. The `pkg_resources` code checks for dependencies in the installed
    `METADATA` file of `isort`, finds that `futures` is an unconditional
    dependency due to point 4 above, fails to find `futures` due to
    point 3 above, and fails with `pkg_resources.DistributionNotFound`
    error.

The issue is resolved by upgrading `setuptools` to the latest version in
Travis CI build environment for Python 3.4. The l... (continued)

Pull Request Pull Request #45: Rename initialization parameters in AzureCloud

Run Details

78 of 111 branches covered (70.27%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

467 of 590 relevant lines covered (79.15%)

2.37 hits per line