cloudmarker / cloudmarker

76%

master: 84%

LAST BUILD ON BRANCH fixcoverage

branch: fixcoverage

CHANGE BRANCH

x

Reset

• fixcoverage
• 0.1.0
• alertdocs
• apidocindent
• audit-version
• auditemails
• azcloud
• azstorage
• azurecloud
• azurecloud-exception
• azvm_record_type
• azwebapp
• badges
• baseconfig
• bracket
• buckets
• build-matrix
• changelog
• clioptions
• clouderror
• common-plugins-config
• consistency
• copy-ext
• copyext
• cov_clean
• dependabot/pip/cryptography-3.3.2
• dependabot/pip/httplib2-0.18.0
• dependabot/pip/httplib2-0.19.0
• dependabot/pip/pyyaml-5.4
• dependabot/pip/rsa-4.7
• dependabot/pip/urllib3-1.26.5
• dist
• docfixes
• doctest-fix
• email_debug_param_from_config
• emailbody
• emaildocs
• empty-port
• esstore
• firewalleventtest
• firewallnorm
• firewallruleevent
• fix-esstore-done
• fix-unused-input-queue
• fix_cloud_worker
• fixbuild
• fixindent
• freeze
• gcpcloudlogs
• gcpcloudtest
• iam_policy
• ignore-virtual-machines
• ioworkers
• key_file_name_fix
• lint
• load_yaml_safely
• log
• logfixes
• logger-defaults
• logging-levels
• master
• maxrecs
• mock-records
• mockplugins
• mongodbdefaults
• mongodbfix
• mongodbtests
• multiprocessing
• pluginframework
• pluginloader
• readable-version
• readme
• remove-email-config
• removefirewallevent
• rename_logger
• renameparams
• requirements
• rest
• reuse-mock
• rm-venv
• slackalert
• smtpssl
• sphinx
• sphinx-rst-update
• splunkfixes
• splunkhecstore_docs
• splunkhectokentest
• splunkstore
• sub_id_rename
• tests
• travis
• userconfig
• userdoc
• userecordterm
• verdev
• webapp
• worker-com-fields
• worker-error-handling
• workerlogs

Build # 237

Build Type

Pull #35

travis-ci-com

Committed by web-flow

Commit Message

Do not run 'clean' target before running 'lint'

This change fixes an issue introduced in commit
1ee640a60 which we will call as the
*faulty commit*. The faulty commit made the `lint` target depend on the
`clean` target, so that the `clean` target is run before the `lint`
target. That change was done so that `build/*` files (created by the
invocation of `setup` module in `cloudmarker/test/test_setup.py`) were
removed before the linters are run, otherwise the linters would detect
problems in the `build` directory too.

While the faulty commit solved the problem described in the previous
paragraph, it also introduced a new issue in Travis CI environment.
Travis CI configuration in `.travis.yml` shows that after `make checks`
is run, the `coveralls` command is run which uploads the test coverage
results to Coveralls ( https://coveralls.io/ ). But when the `coveralls`
command runs, the test coverage results no longer exist. The `checks`
target invokes `lint` as a dependency which in turn invokes `clean` as a
dependency and the `clean` target removes the test coverage results.

Due to this issue, no coverage results are available in Coveralls ever
since that change was done. See https://coveralls.io/repos/242255/builds
to confirm that there is no coverage data after build 104.

This change resolves this issue by undoing the change in that commit.
Further, to resolve the original issue of preventing the linters from
reporting errors in `build/*` directory, Pylama and isort are being
invoked with `skip` and `--skip-glob` options, respectively, to skip
files in the `build` directory.

Pull Request Pull Request #35: Do not run 'clean' target before running 'lint'

Run Details

64 of 99 branches covered (64.65%)

Branch coverage included in aggregate %.

380 of 487 relevant lines covered (78.03%)

2.34 hits per line