chrisns / repomanager

88%

master: 86%

LAST BUILD ON BRANCH fix-consent-issue-loop

branch: fix-consent-issue-loop

CHANGE BRANCH

x

Reset

• fix-consent-issue-loop
• bumpversions
• codex/extend-test-with-owner-and-repo-config-mock
• codex/fix-link-rendering-in-readme.md
• codex/modify-cron-to-filter-by-promise-status
• codex/update-for-new-serverless-version
• codex/update-instances-of-__defalt_branch__-to-__default_branch__
• dependabot/npm_and_yarn/axios-1.11.0
• dependabot/npm_and_yarn/axios-1.15.0
• dependabot/npm_and_yarn/axios-1.7.4
• dependabot/npm_and_yarn/axios-1.8.2
• dependabot/npm_and_yarn/fast-xml-builder-1.2.0
• dependabot/npm_and_yarn/flatted-3.4.2
• dependabot/npm_and_yarn/follow-redirects-1.15.6
• dependabot/npm_and_yarn/glob-10.5.0
• dependabot/npm_and_yarn/jws-3.2.3
• dependabot/npm_and_yarn/katex-0.16.21
• dependabot/npm_and_yarn/lodash-4.17.23
• dependabot/npm_and_yarn/multi-40f7270a74
• dependabot/npm_and_yarn/multi-560224073f
• dependabot/npm_and_yarn/multi-5f49772b58
• dependabot/npm_and_yarn/multi-6c05a6c7dd
• dependabot/npm_and_yarn/multi-8c3730b1f1
• dependabot/npm_and_yarn/multi-8eef569b89
• dependabot/npm_and_yarn/multi-99f0b7984e
• dependabot/npm_and_yarn/multi-bf05dc1ecf
• dependabot/npm_and_yarn/multi-bf4941b406
• dependabot/npm_and_yarn/octokit/endpoint-9.0.6
• dependabot/npm_and_yarn/octokit/request-error-5.1.1
• dependabot/npm_and_yarn/qs-6.14.1
• dependabot/npm_and_yarn/qs-6.14.2
• dependabot/npm_and_yarn/shell-quote-1.8.4
• fixing_eslint
• master
• modernize-consent-workflow
• renovate/actions-cache-3.x
• renovate/actions-cache-4.x
• renovate/actions-cache-5.x
• renovate/actions-checkout-3.x
• renovate/actions-checkout-4.x
• renovate/actions-checkout-5.x
• renovate/actions-checkout-6.x
• renovate/actions-checkout-rollback
• renovate/actions-download-artifact-4.x
• renovate/actions-download-artifact-8.x
• renovate/actions-setup-node-3.x
• renovate/actions-setup-node-4.x
• renovate/actions-setup-node-5.x
• renovate/actions-setup-node-6.x
• renovate/actions-upload-artifact-3.x
• renovate/actions-upload-artifact-4.x
• renovate/actions-upload-artifact-7.x
• renovate/aws-actions-configure-aws-credentials-3.x
• renovate/aws-actions-configure-aws-credentials-4.x
• renovate/aws-actions-configure-aws-credentials-5.x
• renovate/aws-actions-configure-aws-credentials-6.x
• renovate/aws-actions-configure-aws-credentials-digest
• renovate/aws-actions-setup-sam-2.x
• renovate/aws-actions-setup-sam-3.x
• renovate/aws-actions-setup-sam-digest
• renovate/aws-actions-setup-sam-rollback
• renovate/aws-sdk-js-v3-monorepo
• renovate/eslint-8.x
• renovate/eslint-9.x
• renovate/eslint-compat-1.x-lockfile
• renovate/eslint-compat-2.x
• renovate/eslint-compat-2.x-lockfile
• renovate/eslint-config-prettier-10.x
• renovate/eslint-config-prettier-10.x-lockfile
• renovate/eslint-config-prettier-8.x
• renovate/eslint-config-prettier-9.x
• renovate/eslint-eslintrc-3.x-lockfile
• renovate/eslint-js-9.x-lockfile
• renovate/eslint-monorepo
• renovate/eslint-plugin-import-2.x
• renovate/eslint-plugin-n-16.x
• renovate/eslint-plugin-n-17.x
• renovate/eslint-plugin-prettier-5.x
• renovate/globals-15.x-lockfile
• renovate/globals-16.x
• renovate/globals-16.x-lockfile
• renovate/globals-17.x
• renovate/globals-17.x-lockfile
• renovate/jest-29.x
• renovate/jest-monorepo
• renovate/lock-file-maintenance
• renovate/major-eslint-monorepo
• renovate/major-github-artifact-actions
• renovate/major-jest-monorepo
• renovate/major-octokit-monorepo
• renovate/markdownlint-0.x
• renovate/markdownlint-cli-0.x
• renovate/nock-14.x-lockfile
• renovate/node-16.x
• renovate/node-18.x
• renovate/node-20.3.0-alpine
• renovate/node-20.3.1-alpine
• renovate/node-20.4.0-alpine
• renovate/node-20.5.0-alpine
• renovate/node-20.5.1-alpine
• renovate/node-20.6.0-alpine
• renovate/node-20.6.1-alpine
• renovate/node-20.7.0-alpine
• renovate/node-20.8.0-alpine
• renovate/node-20.8.1-alpine
• renovate/node-20.x
• renovate/node-21.0.0-alpine
• renovate/node-21.1.0-alpine
• renovate/node-21.2.0-alpine
• renovate/node-21.3.0-alpine
• renovate/node-21.4.0-alpine
• renovate/node-21.5.0-alpine
• renovate/node-21.6.0-alpine
• renovate/node-21.6.1-alpine
• renovate/node-21.6.2-alpine
• renovate/node-21.7.0-alpine
• renovate/node-21.7.1-alpine
• renovate/node-21.7.2-alpine
• renovate/node-21.7.3-alpine
• renovate/node-21.x
• renovate/node-22.11.0-alpine
• renovate/node-22.12.0-alpine
• renovate/node-22.13.0-alpine
• renovate/node-22.14.0-alpine
• renovate/node-22.16.0-alpine
• renovate/node-22.17.0-alpine
• renovate/node-22.17.1-alpine
• renovate/node-22.20.0-alpine
• renovate/node-22.21.0-alpine
• renovate/node-22.x
• renovate/node-24.11.0-alpine
• renovate/node-24.12.0-alpine
• renovate/node-24.14.1-alpine
• renovate/node-24.x
• renovate/npm-run-all-replacement
• renovate/npm-run-all2-5.x
• renovate/npm-run-all2-6.x
• renovate/npm-run-all2-7.x
• renovate/npm-run-all2-8.x
• renovate/octokit-auth-app-5.x-lockfile
• renovate/octokit-monorepo
• renovate/octokit-plugin-create-pull-request-5.x-lockfile
• renovate/octokit-plugin-paginate-rest-7.x-lockfile
• renovate/octokit-rest-19.x-lockfile
• renovate/pin-dependencies
• renovate/prettier-3.x
• renovate/prettier-3.x-lockfile
• renovate/serverless-3.x-lockfile
• renovate/serverless-4.x
• renovate/yaml-2.x-lockfile
• renovate/zod-4.x-lockfile
• repomanager_files
• revert-1364-codex/modify-cron-to-filter-by-promise-status
• shrink
• snyk-fix-f0846978cd1c4b4b8e54038da7c88c55

Build # 24935518485

Build Type

Pull #1584

github

Committed by chrisns

Commit Message

Stop the bot from looping on its own consent-issue edits

Three coupled defensive fixes to break the re-fire loop seen during a
bulk-tick of 30 consent issues, where each markItemsApplied write
triggered another issues.edited, which re-ran applyConsentedChanges,
which re-tried createPullRequest and tripped on "Pull request already
exists":

* handleIssuesEdited now ignores edits whose sender is a Bot account
  (the-repository-manager[bot] in particular). The bot's own writes
  must not feed back into apply work.

* applyConsentedChanges only acts on items that are checked AND not
  already applied (struck through) AND not failed (⚠️). Idempotent
  apply calls don't pay the cost of redoing work, and non-idempotent
  ones (createPullRequest) don't error out on "already exists".

* applyFiles passes update: true to octokit-plugin-create-pull-request
  so retries against an existing open PR are no-ops rather than
  failures.

Pull Request Pull Request #1584: Stop bot looping on its own consent-issue edits

Coverage Stats

245 of 312 branches covered (78.53%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

484 of 518 relevant lines covered (93.44%)

12.95 hits per line