chrisns / repomanager / 24935518485

88%

master: 85%

Pull #1584

github

Stop the bot from looping on its own consent-issue edits

Three coupled defensive fixes to break the re-fire loop seen during a
bulk-tick of 30 consent issues, where each markItemsApplied write
triggered another issues.edited, which re-ran applyConsentedChanges,
which re-tried createPullRequest and tripped on "Pull request already
exists":

* handleIssuesEdited now ignores edits whose sender is a Bot account
  (the-repository-manager[bot] in particular). The bot's own writes
  must not feed back into apply work.

* applyConsentedChanges only acts on items that are checked AND not
  already applied (struck through) AND not failed (⚠️). Idempotent
  apply calls don't pay the cost of redoing work, and non-idempotent
  ones (createPullRequest) don't error out on "already exists".

* applyFiles passes update: true to octokit-plugin-create-pull-request
  so retries against an existing open PR are no-ops rather than
  failures.

245 of 312 branches covered (78.53%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

484 of 518 relevant lines covered (93.44%)

12.95 hits per line