chavic / rust-payjoin

85%

master: 86%

LAST BUILD ON BRANCH chavic/ffi-string-implementation-error-audit

branch: chavic/ffi-string-implementation-error-audit

CHANGE BRANCH

x

Reset

Sync Branches

• chavic/ffi-string-implementation-error-audit
• add-uniffi-dart-repo
• bech32-uppercase-assertion
• chavic/backup-uniform-primitive-types
• chavic/bdk-patch-regressions-fixes
• chavic/c-sharp-bindings
• chavic/csharp-ffi-validation-catchup
• chavic/csharp-nix-devshell
• chavic/csharp-nuget-release-readiness-1448
• chavic/dart-fetch-ohttp-keys-https
• chavic/ffi-cleanup
• chavic/ffi-session-history-renaming
• chavic/ffi-string-impl-audit
• chavic/fix-ffi-devshell-followups
• chavic/fix-lint-result-large-err
• chavic/inputpair-outpoint-ffi
• chavic/json-reply-accessors-1271
• chavic/ohttp-hpke-error-variants-1273
• chavic/persisted-replay-errors-1275
• chavic/primitives-validatation-errors
• chavic/primitives-validatation-errors-old
• chavic/primitives-validation
• chavic/psbt-input-error-index-1276
• chavic/receiver-error-variants-1270
• chavic/retry-expiration-metadata-1272
• chavic/substitution-contribution-errors-1277
• chavic/uniform-primities-types-backup16dec
• chavic/uniform-primitive-type-at-ffi-boundary-backup-after-rebase
• chavic/uniform-primitive-types-at-ffi-boundary
• chavic/uniform-primitive-types-at-ffi-boundary-8-12-2025-backup
• master
• replay-event-log-async
• spelling-fixes
• test/FetchOhttpKeys

Build # 18045154457

Build Type

push

github

Committed by spacebear21

Commit Message

Panic on RwLock errors in FFI wrappers

Crashing the process on a concurrent access attempt seems acceptable
because it's a concurrency issue on the host's side; only one process
should be progressing the payjoin session state. And mapping this type
of error to ImplementationError suggests that the error is recoverable
when it's actually a fatal programming error.

Coverage Stats

8080 of 9542 relevant lines covered (84.68%)

489.83 hits per line