bugsnag / bugsnag-android

70%

master: 83%

LAST BUILD ON BRANCH kattrali/switch-by-wordsize

branch: kattrali/switch-by-wordsize

CHANGE BRANCH

x

Reset

• kattrali/switch-by-wordsize
• add-async-error-flush-scenario
• add-breadcrumb-scenario
• add-cache-scenario
• add-client-accessors
• add-context-scenario
• add-cpuabi
• add-filter-scenarios
• add-git-hooks
• add-ignored-scenarios
• add-jsonwriter-test
• add-kotlin
• add-mavencentral-repo
• add-maze-harness
• add-metadata-scenari
• add-payload-version
• add-session-track-setter
• add-set-auto-capture-scenario
• add-unity-jni-methods
• add-unusual-crash-scenarios
• additional-multi-client-scenarios
• address-flaky-tests
• address-operator-codestyle-warnings
• alter-config-visibility
• android-anr-detection
• android-p-compat
• android-p-flush-fix
• android-unity-changes
• anr-ci
• anr-detection
• anr-detection-ndk
• anr-unity
• anr-unity-native-interface
• api-client-safety
• app-data-collection
• app-version-override
• appdata-changes
• async-error-store-tests
• async-test-fix
• before-breadcrumb-filter
• before-notify-concurrency
• bengourley/disable-anr-default
• breadcrumb-accessor
• breadcrumb-name-fix
• buildkite-move
• cancel-bg-test-tasks
• catch-delivery-exception
• cawllec/test-anr-detection
• ci-cache
• client-breadcrumbs-code-cov
• client-metadata-code-cov
• code-cov-badge
• combine-ndk-with-sdk
• cpu-abi-payload-migration
• delivery-api-change
• delivery-api-tests
• detect-emulator
• device-data-changes
• device-data-collection
• enable-checkstyle
• enable-code-coverage-task
• enable-session-tracking
• error-changes
• error-deserialisation-refactor
• event-metadata-scenario
• fail-on-compiler-warnings
• filestore-thread-safety
• fix-ci
• fix-error-deserialisation
• fix-google-artifact-resolution
• fix-metadata-filters
• flaky-test-experiments
• gracecheung-github-seo
• handled-exception-scenario
• improve-client-code-cov
• improve-client-config-code-cov
• improve-config-code-cov
• improve-error-code-cov
• improve-metadata-code-cov
• improve-notify-code-cov
• improve-report-code-cov
• improve-session-code-cov
• in-foreground
• in-foreground-fixes
• init-safety
• inspection-fixes
• jni-rework
• json-empty-file-case
• kattrali/add-r19-to-build-matrix
• kattrali/before-send-callback
• kattrali/build-ndk
• kattrali/cleanup-test-fixtures
• kattrali/coveralls
• kattrali/cpp-handler
• kattrali/cppcheck-fixes
• kattrali/custom-abi-filters
• kattrali/deregister-listener-tests
• kattrali/fix-arm32-stack-resolver
• kattrali/move-examples-into-subdir
• kattrali/ndk-ci
• kattrali/ndk-integrate
• kattrali/ndk-reduce-surface
• kattrali/pop-cache-segfault
• kattrali/record-build-stats
• kattrali/release-v4.3.3
• kattrali/sigquit-anr
• kattrali/split-handlers
• kattrali/test-build-flags
• kattrali/unity-sync-all
• kattrali/unity-sync-session-ndk
• kattrali/unset-context
• kattrali/update-release-guide
• localised-message-ndk-fix
• make-android-lint-strict
• martin308/android-unity
• martin308/breadcrumb-timestamp
• master
• mazerunner-ci
• mazerunner-perf-improvement
• mazerunner-speed
• metadata-merge-fix
• multi-client-scenario
• multi-client-storage
• next
• notifier-changes
• notify-breadcrumb-fix
• null-annotations-bugsnag
• null-annotations-client
• null-annotations-config
• null-annotations-native-interface
• null-annotations-remaining
• null-system-service
• proguard-consumer-files
• project-packages-fix
• property-access-fixes
• refactor-client-init
• refactor-field-can-be-local
• refactor-final-modifier
• refactor-language-level-migration
• refactor-nullability-annotations
• refactor-presized-array-call
• refactor-redundant-constructs
• refactor-redundant-local-variable
• refactor-unused-imports
• refine-breadcrumb-auto-capture
• release-stage-scenario
• remove-duplicate-keys
• remove-french-translation
• remove-obsolete-test
• renovate/configure
• renovate/gradle-4.x
• renovate/gradle-5.x
• report-changes
• resolve-flaky-tests
• resolve-unknown-nullness-issues
• resume-session-null-check
• runtime-versions
• send-binary-arch
• session-count-fix
• session-scenarios
• setup-findbugs
• setup-infer
• setup-kotlin
• setup-mazerunner-ci
• simplify-test-teardown
• split-plugin-repro-case
• stackframe-limit
• stop-sessions
• stop-sessions-docs
• stop-sessions-mazerunner-tests
• stop-sessions-ndk
• strictmode-disk-fix
• strictmode-fixes
• strictmode-root-check
• strictmode-scenarios
• swallow-lifecycle-breadcrumb-exc
• thread-id
• thread-id-mazerunner
• track-dex-count
• unhandled-exception-scenario
• unit-test-fix
• unity-serialisation-changes
• update-agp-version
• update-android-studio-3.3
• update-changelog-wording
• update-context-tracking
• update-contributing-guidelines
• update-gson-dep
• update-infer-setup
• update-logo
• update-makefile-steps
• update-pr-template
• update-proguard-rules
• update-release-command
• update-release-notes
• update-release-steps
• update-travis
• update-travis-matrix
• upgrade-checkstyle
• use-api-28-version-code
• use-buffered-streams
• user-changes
• user-scenario
• v4.10.0
• v4.11.0
• v4.12.0
• v4.14.1
• v4.14.2
• v4.3.2
• v4.3.3
• v4.3.4
• v4.4.0
• v4.4.1
• v4.5.0
• v4.6.0
• v4.9.0
• v4.9.1
• v4.9.2
• v4.9.3

Build # 171

Build Type

Pull #383

travis-ci-com

Committed by web-flow

Commit Message

fix: Only set stack registers / exit unwind early on 32-bit

Uses the ABI list to conditionally switch unwinders on ARM.

While the stack enhancements added in #378 are intended only to be run
on 32-bit devices and gated to the __arm__ build, when 64-bit devices
are running the 32-bit library, the stacktraces for those devices were
unintentionally affected. This is the case when an app is configured to
only run 32-bit binaries (Android cannot run both 64-bit and 32-bit
binaries at once), and many popular libraries (e.g. React Native) only
distribute 32-bit libraries.

To further improve the stack quality on 32-bit, switches the underlying
unwinder from gnu unwind to non-gnu libunwind. Improves frame resolution
and does not have the crash in unwind when setting registers.

Fixes #382

Pull Request Pull Request #383: fix(ndk): Ensure 64-bit devices running 32-bit binaries do not use 32-bit device unwinding logic

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

1134 of 1622 relevant lines covered (69.91%)

1.4 hits per line