bugsnag / bugsnag-android

69%

master: 83%

LAST BUILD ON BRANCH refactor-presized-array-call

branch: refactor-presized-array-call

CHANGE BRANCH

x

Reset

• refactor-presized-array-call
• add-async-error-flush-scenario
• add-breadcrumb-scenario
• add-cache-scenario
• add-client-accessors
• add-context-scenario
• add-cpuabi
• add-filter-scenarios
• add-git-hooks
• add-ignored-scenarios
• add-jsonwriter-test
• add-kotlin
• add-mavencentral-repo
• add-maze-harness
• add-metadata-scenari
• add-payload-version
• add-session-track-setter
• add-set-auto-capture-scenario
• add-unity-jni-methods
• add-unusual-crash-scenarios
• additional-multi-client-scenarios
• address-flaky-tests
• address-operator-codestyle-warnings
• alter-config-visibility
• android-anr-detection
• android-p-compat
• android-p-flush-fix
• android-unity-changes
• anr-ci
• anr-detection
• anr-detection-ndk
• anr-unity
• anr-unity-native-interface
• api-client-safety
• app-data-collection
• app-version-override
• appdata-changes
• async-error-store-tests
• async-test-fix
• before-breadcrumb-filter
• before-notify-concurrency
• bengourley/disable-anr-default
• breadcrumb-accessor
• breadcrumb-name-fix
• buildkite-move
• cancel-bg-test-tasks
• catch-delivery-exception
• cawllec/test-anr-detection
• ci-cache
• client-breadcrumbs-code-cov
• client-metadata-code-cov
• code-cov-badge
• combine-ndk-with-sdk
• cpu-abi-payload-migration
• delivery-api-change
• delivery-api-tests
• detect-emulator
• device-data-changes
• device-data-collection
• enable-checkstyle
• enable-code-coverage-task
• enable-session-tracking
• error-changes
• error-deserialisation-refactor
• event-metadata-scenario
• fail-on-compiler-warnings
• filestore-thread-safety
• fix-ci
• fix-error-deserialisation
• fix-google-artifact-resolution
• fix-metadata-filters
• flaky-test-experiments
• gracecheung-github-seo
• handled-exception-scenario
• improve-client-code-cov
• improve-client-config-code-cov
• improve-config-code-cov
• improve-error-code-cov
• improve-metadata-code-cov
• improve-notify-code-cov
• improve-report-code-cov
• improve-session-code-cov
• in-foreground
• in-foreground-fixes
• init-safety
• inspection-fixes
• jni-rework
• json-empty-file-case
• kattrali/add-r19-to-build-matrix
• kattrali/before-send-callback
• kattrali/build-ndk
• kattrali/cleanup-test-fixtures
• kattrali/coveralls
• kattrali/cpp-handler
• kattrali/cppcheck-fixes
• kattrali/custom-abi-filters
• kattrali/deregister-listener-tests
• kattrali/fix-arm32-stack-resolver
• kattrali/move-examples-into-subdir
• kattrali/ndk-ci
• kattrali/ndk-integrate
• kattrali/ndk-reduce-surface
• kattrali/pop-cache-segfault
• kattrali/record-build-stats
• kattrali/release-v4.3.3
• kattrali/sigquit-anr
• kattrali/split-handlers
• kattrali/switch-by-wordsize
• kattrali/test-build-flags
• kattrali/unity-sync-all
• kattrali/unity-sync-session-ndk
• kattrali/unset-context
• kattrali/update-release-guide
• localised-message-ndk-fix
• make-android-lint-strict
• martin308/android-unity
• martin308/breadcrumb-timestamp
• master
• mazerunner-ci
• mazerunner-perf-improvement
• mazerunner-speed
• metadata-merge-fix
• multi-client-scenario
• multi-client-storage
• next
• notifier-changes
• notify-breadcrumb-fix
• null-annotations-bugsnag
• null-annotations-client
• null-annotations-config
• null-annotations-native-interface
• null-annotations-remaining
• null-system-service
• proguard-consumer-files
• project-packages-fix
• property-access-fixes
• refactor-client-init
• refactor-field-can-be-local
• refactor-final-modifier
• refactor-language-level-migration
• refactor-nullability-annotations
• refactor-redundant-constructs
• refactor-redundant-local-variable
• refactor-unused-imports
• refine-breadcrumb-auto-capture
• release-stage-scenario
• remove-duplicate-keys
• remove-french-translation
• remove-obsolete-test
• renovate/configure
• renovate/gradle-4.x
• renovate/gradle-5.x
• report-changes
• resolve-flaky-tests
• resolve-unknown-nullness-issues
• resume-session-null-check
• runtime-versions
• send-binary-arch
• session-count-fix
• session-scenarios
• setup-findbugs
• setup-infer
• setup-kotlin
• setup-mazerunner-ci
• simplify-test-teardown
• split-plugin-repro-case
• stackframe-limit
• stop-sessions
• stop-sessions-docs
• stop-sessions-mazerunner-tests
• stop-sessions-ndk
• strictmode-disk-fix
• strictmode-fixes
• strictmode-root-check
• strictmode-scenarios
• swallow-lifecycle-breadcrumb-exc
• thread-id
• thread-id-mazerunner
• track-dex-count
• unhandled-exception-scenario
• unit-test-fix
• unity-serialisation-changes
• update-agp-version
• update-android-studio-3.3
• update-changelog-wording
• update-context-tracking
• update-contributing-guidelines
• update-gson-dep
• update-infer-setup
• update-logo
• update-makefile-steps
• update-pr-template
• update-proguard-rules
• update-release-command
• update-release-notes
• update-release-steps
• update-travis
• update-travis-matrix
• upgrade-checkstyle
• use-api-28-version-code
• use-buffered-streams
• user-changes
• user-scenario
• v4.10.0
• v4.11.0
• v4.12.0
• v4.14.1
• v4.14.2
• v4.3.2
• v4.3.3
• v4.3.4
• v4.4.0
• v4.4.1
• v4.5.0
• v4.6.0
• v4.9.0
• v4.9.1
• v4.9.2
• v4.9.3

Build # 707

Build Type

Pull #461

travis-ci-com

Committed by web-flow

Commit Message

refactor: prefer using zero-based array when converting collection

There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]).

In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation.

This inspection allows to follow the uniform style: either using an empty array (which is recommended in modern Java) or using a pre-sized array (which might be faster in older Java versions or non-HotSpot based JVMs).

Pull Request Pull Request #461: Prefer using zero-based array when converting collection

Run Details

4 of 4 new or added lines in 3 files covered. (100.0%)

2266 of 3286 relevant lines covered (68.96%)

2.07 hits per line