brotherlogic / recordcollection

53%

master: 62%

LAST BUILD ON BRANCH scrub-negative-instance-ids-from-caches

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• adjust-cmd-all-query
• aha
• auto-remove-blocked-from-sale
• boing
• bounder
• enable_expire
• enhance-readme
• fast_updates
• fix
• fix-adjust-cli-sold-archive
• fix-memory-and-connection-leaks
• fix-metadata-instance-id
• fix-pull-blocked-cli
• fix/clean-validate-iids-9198
• fix/negative-instance-id
• fix/queryrecords-clean-validate-9199
• fix_location
• fix_proto
• fix_purchase_location
• fix_sale
• fix_update
• fix_width
• fixer
• fixer2
• fry
• last-week-listens-cli
• main
• master
• quickfix
• sale-description-generator
• scrub-negative-instance-ids-from-caches
• support_location
• support_rip
• update
• update-1733893256
• update-1734499359
• update-1734499504
• update-1734499595
• update-1734826256
• update-1734830056
• update-1734837392
• update-1734841039
• update-1734844678
• update-1734859279
• update-1734880933
• update-1734884563
• update-1734888175
• update-1734891844
• update-1734895429
• update-1734902722
• update-1734910072
• update-1734913787
• update-1734917452
• update-1734924852
• update-1734928523
• update-1734932248
• update-1734946806
• update-1734950431
• update-1734957718
• update-1734961341
• update-1734968588
• update-1734990732
• update-1735001659
• update-1735005349
• update-1735012771
• update-1735020092
• update-1735023713
• update-1735027460
• update-1735031224
• update-1735046020
• update-1735049799
• update-1735057358
• update-1735061055
• update-1735075561
• update-1735097552
• update-1735101128
• update-1735104919
• update-1735108660
• update-1735115776
• update-1735130608
• update-1735134329
• update-1735138056
• update-1735141811
• update-1735149216
• update-1735160005
• update-1735185986
• update-1735189412
• update-1735193301
• update-1735196836
• update-1735200431
• update-1735207953
• update-1735211430
• update-1735215056
• update-1735218728
• update-1735226068
• update-1735244387
• update-1735266342
• update-1735270006
• update-1735273521
• update-1735277392
• update-1735284677
• update-1735291939
• update-1735295545
• update-1735299214
• update-1735302711
• update-1735306586
• update-1735310165
• update-1735317569
• update-1735321089
• update-1735324739
• update-1735335909
• update-1735339370
• update-1735342902
• update-1735346631
• update-1735350412
• update-1735357704
• update-1735372484
• update-1735390706
• update-1735401512
• update-1735408952
• update-1735416432
• update-1735430692
• update-1735434342
• update-1735438076
• update-1735441809
• update-1735445498
• update-1735452957
• update-1735474603
• update-1735477995
• update-1735496462
• update-1735503444
• update-1735510752
• update-1735514263
• update-1735518042
• update-1735528808
• update-1735536221
• update-1735540171
• update-1735543575
• update-1735547133
• update-1735554779
• update-1735576268
• update-1735583681
• update-1735605539
• update-1735609245
• update-1735612747
• update-1735620319
• update-1735627373
• update-1735631201
• update-1735634694
• update-1735638511
• update-1735642484
• update-1735649601
• update-1735660584
• update-1735664368
• update-1735668088
• update-1735671650
• update-1735675528
• update-1735686586
• update-1735693985
• update-1735697426
• update-1735701059
• update-1735708618
• update-1735715895
• update-1735719863
• update-1735730581
• update-1735737937
• update-1735745035
• update-1735748752
• update-1735752648
• update-1735756524
• update-1735767036
• update-1735770884
• update-1735781725
• update-1735789200
• update-1735800152
• update-1735803795
• update-1735807719
• update-1735814927
• update-1735818710
• update-1735822570
• update-1735825890
• update-1735829525
• update-1735833048
• update-1735836746
• update-1735841945
• update-1735842874
• update-1735843124
• update-1735843473
• update-1735843816
• update-1735844451
• update-1736617412
• update-1736808010
• update-1737492774
• update-1743723892
• update-1744329454
• update-1744934600
• update-1745540579
• update-1747048145
• update-1747960389
• update-1748894384
• update-1748894792
• update-1748895170
• update-1748895507
• update-1748896701
• update-1748897275
• update-1748897864
• update-1748898093
• update-1748898274
• update-1748898818
• update-1748899327
• update-1748899925
• update-1748900714
• update-1748901004
• update-1748902251
• update-1748903574
• update-1748904207
• update-1748904703
• update-1748905275
• update-1748906313
• update-1748906983
• update-1748907209
• update-1748908350
• update-1748909152
• update-1749514776

Build # 27041931923

Build Type

Pull #9205

github

Committed by brotherlogic

Commit Message

Scrub negative instance IDs from all cache maps on startup

On readRecordCollection, any negative key in the eight cache maps
(InstanceToFolder, InstanceToCategory, InstanceToUpdate,
InstanceToUpdateIn, InstanceToMaster, InstanceToId, InstanceToRecache,
InstanceToLastSalePriceUpdate) is now deleted before the collection is
returned. If any entries were removed the cleaned collection is saved
back to the keystore so the stale data does not reappear on the next
restart.

Previously only InstanceToCategory had a scrub loop. The other seven
maps could still contain legacy negative IDs caused by historical
int32 overflow, which would propagate into query results.

A generic helper negativeKeysToDelete[V any] avoids repeating the
delete-loop boilerplate for each map.

Tests:
- Added TestNegativeIdNotInCacheAfterRead to drive the new behaviour
- Updated TestQueryRecordsWithNegativeId to match: negative IDs saved
  directly into the keystore must not appear in QueryRecords results
  after the next readRecordCollection call.

Pull Request Pull Request #9205: Scrub negative instance IDs from all cache maps on startup

Coverage Stats

704 of 1329 relevant lines covered (52.97%)

0.61 hits per line