broadinstitute / cromwell
71%
develop: 95%

LAST BUILD BRANCH: aws-tutorial
DEFAULT BRANCH: develop
Repo Added
Files 11
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH ks_runtime_attribute_edits
branch: ks_runtime_attribute_edits
CHANGE BRANCH
x

11490

push

travis-ci

kshakir 
Updates for Standard backends.
JES now uses the uncustomized sync standard actor.
Moved primitive runtime attributes validators to standard.
Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard.
Moved the SFS initialization data to standard.
JES and Standard backends now use VRAB within their backends via initialization data.
Primitive runtime attribute validations now handle basic `WdlString` conversion to Boolean/Float/Integer.
Merged code for continue on return code expression validation, from BackendWorkflowInitializationActor and ContinueOnReturnCodeValidation.
Added a BackendWorkflowInitializationActorSpec.
Updated ContinueOnReturnCodeValidation to also allow boolean strings `"true"` and `"false"`.
The standard async backend pulls failOnStdErr and continueOnReturnCode from those generated by the VRAB.
JesRuntimeAttributes (JRA) generation now extracts values from the the map build by the the VRAB.
Realized based on the JRA Spec that the VRAB failure messages need to differentiate missing vs. bad.
When encountering invalid runtime attributes, the validation should (optionally) say what the bad value is (see Jes' NoAddressValidation).
Plumbed the synchronous actor of the job actor method params into the param-traits used by Standard.
Moved the SFS path builders from the SFS factory to the SFS init actor.
New standard cache-hit-copying actor trait, plus consolidation of the cache-hit-copying and async actors into a new standard helper trait.
SharedFileSystemJob.JobIdKey is now SharedFileSystemAsyncJobExecutionActor.JobIdKey.
WorkflowPaths.toJobPaths now takes into account that jobs for sub workflow use a different workflow descriptor than the workflow.
Merged WorkflowPathsBackendInitializationData into StandardInitializationData.
New standard finalization trait.
Changed JES runtime attributes (JRA) to always require docker.
Updated JRA spec match new required docker.
While updating spec, changed JRA spec to match the primitive validator messages.

4842 of 6867 relevant lines covered (70.51%)

0.71 hits per line

Relevant lines Covered
6867 RELEVANT LINES 4842 COVERED LINES
0.71 HITS PER LINE
Source Files on ks_runtime_attribute_edits
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
11490 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
11486 ks_runtime_attribute_edits With reviewer blessing to touch the JRA spec, a few updates. Changed JES runtime attributes (JRA) to always require docker. Updated JRA spec match new required docker. While updating spec, changed JRA spec to match the original primitive validator... push kshakir travis-ci pending completion  
11484 ks_runtime_attribute_edits Switched standard params from `val` to the safer `def` push kshakir travis-ci pending completion  
11477 ks_runtime_attribute_edits PR update for grammar, plus side effects. An init message was requested to be changed, requiring the existing message in the JES init spec to change also. As the spec's expected exception message needed to be edited, there was no need for a custom... push kshakir travis-ci pending completion  
11411 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
11409 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
11407 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
11406 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
11405 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
11404 ks_runtime_attribute_edits Updates for Standard backends. JES now uses the uncustomized sync standard actor. Moved primitive runtime attributes validators to standard. Moved the SFS ValidatedRuntimeAttributesBuilder (VRAB) to standard. Moved the SFS initialization data to s... push kshakir travis-ci pending completion  
See All Builds (9674)