broadinstitute / agora

89%

develop: 88%

LAST BUILD ON BRANCH bt_configuration_validation_bugfix

branch: bt_configuration_validation_bugfix

CHANGE BRANCH

x

Reset

• bt_configuration_validation_bugfix
• 1.0
• AddBasePath
• Dupdate
• GAWB-1829-build-refactor
• GAWB-2094
• ab_cromwell_30
• ab_cromwell_30-2
• ab_environments
• ab_remove_local_config
• ah-mod
• alpha
• an-GAWB-1614-v2
• an-GAWB-2032
• an-GAWB-2468
• an-GAWB-2468-assoc-configs
• an-GAWB-2641
• an-GAWB-2814
• bt_CLI_2
• bt_containerize_travis
• bt_switch_to_pem
• bt_sync_admins_DSDEEPB-1388
• bump_slick
• c27_wdl4s_0.12
• circleci
• da-GAWB-2468-assoc-configs
• da_GAWB-1614_nameValidation
• da_GAWB-1784_entitySnapshotPermissions
• da_GAWB-2038_adminRedact
• da_GAWB-2059_copyEntity
• da_GAWB-2251_multiPermission
• da_GAWB-2252_addMultiPermissions
• da_GAWB-2319_ownerInfo
• da_GAWB-2341_isPublic
• da_GAWB-2342_createAfterRedaction
• da_GAWB-2453_uniqueMethods
• da_GAWB-2455_assocConfigs
• da_GAWB-2455_notFoundErrorMessage
• da_GAWB-2456_compatibleConfigs
• da_GAWB-2669_redactedCompatible
• da_GAWB-2786_compatibleOptional
• da_GAWB-2833_cloneSynopsis
• da_GAWB-3028_agora212
• da_GAWB-3028_removeRawlsModel
• da_GAWB-849_ga4ghApi
• da_GAWB-849_publicGetWdl
• da_gr-GAWB-1236
• da_noKamon
• da_removeSwaggerSpray
• da_scalaCompilerOverride
• da_updateScalatest
• da_upgradeDependencies
• da_upgradeLogback
• da_versionUpdates
• da_wdl4supgrade
• develop
• ds_cli_uri_param
• ds_config_method_relation
• ds_docker_standardize
• ds_more_log_info
• ds_mysql_ssl
• ds_per_request_logging
• ds_reduce_google_api_scope
• ds_validate_configs
• fail-build-script
• fix_guava_conflict
• fix_h2_tests
• fix_text_plain
• gg_DSDEEPB-306_ref_valid_task_docker_images
• gg_DSDEEPB-472_improve_agora_testing
• gg_google_object_acl_get
• gg_temp_disable_docker_ref_validation
• gr-GAWB-1190
• gr-GAWB-1225
• gr-GAWB-1236
• gr-GAWB-849-bug-fix
• gr-GAWB-849-ga4gh
• gr-swagger-fix
• gr-test-harness
• gr_da_GAWB-849_ga4ghApi
• hf_testbranch
• jc_add_scopes
• jc_agora_vault
• jc_config_param
• jc_coverage
• jc_coveralls_fix
• jc_fix_build
• jc_integration_test
• jc_kamon
• jc_mongo_creds
• jc_replicate_mongo
• jc_security_swagger
• jc_test_bucket_exists
• jc_test_refactor
• jc_yaml_swagger
• jprofiler
• jr-test-branch
• jr-test-circleci-removal
• jt_checklist
• kc_fix_agora_tests
• kc_openidc
• ky_update_readme
• ldapauth
• map_harder
• master
• mb_401_to_403
• mb_removeAcl
• new-build
• new_artifactory
• public_permission
• remove_wdl_validation
• revert-178-slick_3.2
• revert-179-revert-178-slick_3.2
• revert-192-da_GAWB-1614_nameValidation
• rt-gawb-2272
• skw_1161
• skw_773
• slick_3.2
• slick_fix
• staging
• swagger2.0
• tex_compose_global
• tex_stackdriver
• tidy_exceptions
• us-GAWB-2354
• validate_wdls
• vault
• vd_500_bug
• vd_PUT_failed
• vd_admin_redact
• vd_batch_permission
• vd_errors
• vd_gcs_client_acls
• vd_method_redact
• vd_permissions_cleanup
• vd_public_permission
• vd_sql_permissions
• vd_swagger_permissions
• vd_swagger_redact
• vd_validation_snapshotId
• vd_vault
• vd_versioning
• wdl4s_0.11_c26

Build # 893

Build Type

push

travis-ci

Committed by bradtaylor

Commit Message

Small bug fix to configuration validation

Rawls changed the configuration payload field "methodStoreMethod" to "methodRepoMethod"
We check for the existence of this field during validation, and we were checking by the old name.

Fixed the field name in the configuration validation
Added better failure descriptions to our require statements
Added a validation exception so that we can avoid catching IllegalArgumentException at perRequest layer
Changed perRequest to respond with BadRequest on validation errors, not IllegalArgumentException
Changed methodStoreMethod -> methodRepoMethod in swagger, static test data

Addressed PR comments

Run Details

787 of 885 relevant lines covered (88.93%)

0.89 hits per line