893
89%
develop: 88%

Ran 14 Sep 2015 05:38PM UTC

Jobs 1

Files 41

Run time 507min

Badge

Embed ▾

pending completion

Build # 893

Build Type

push

travis-ci

Committed by

bradtaylor

Commit Message

Small bug fix to configuration validation

Rawls changed the configuration payload field "methodStoreMethod" to "methodRepoMethod"
We check for the existence of this field during validation, and we were checking by the old name.

Fixed the field name in the configuration validation
Added better failure descriptions to our require statements
Added a validation exception so that we can avoid catching IllegalArgumentException at perRequest layer
Changed perRequest to respond with BadRequest on validation errors, not IllegalArgumentException
Changed methodStoreMethod -> methodRepoMethod in swagger, static test data

Addressed PR comments

Run Details

787 of 885 relevant lines covered (88.93%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	src/main/scala/org/broadinstitute/dsde/agora/server/dataaccess/permissions/AgoraPermissions.scala
1	100.0	src/main/scala/org/broadinstitute/dsde/agora/server/exceptions/ValidationException.scala
1	100.0	src/main/scala/org/broadinstitute/dsde/agora/server/model/AgoraApiJsonSupport.scala
3	100.0	src/main/scala/org/broadinstitute/dsde/agora/server/business/AgoraBusiness.scala

Jobs

ID	Job ID	Ran	Files	Coverage
1	893.1	14 Sep 2015 05:38PM UTC	0	88.93	Travis Job 893.1

Source Files on build 893

Detailed source file information is not available for this build.

broadinstitute / agora / 893
89%
develop: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 893

broadinstitute / agora / 893 89% develop: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 893

broadinstitute / agora / 893
89%
develop: 88%

README BADGES
x