block / mysql / 30870374728

83%

push

github

conn: add unified QueryResultContext for arbitrary SQL (#1)

* conn: add unified QueryResultContext for arbitrary SQL

A caller that receives arbitrary SQL (a proxy, a REPL) must classify each
statement before executing it, because database/sql forces the choice
between QueryContext and ExecContext up front — and a misclassification
either discards a resultset (Exec) or loses the OK metadata (Query). The
MySQL protocol itself never needed the decision in advance: a COM_QUERY
response is self-describing (an OK packet or a column-count packet).

QueryResultContext surfaces exactly that: it executes a statement and
returns (rows, nil) for a resultset response or (nil, result) for an OK
response. The body mirrors mysqlConn.query verbatim, except an OK response
is reported the way Exec reports it instead of being hidden inside an
empty, done resultset. Reached through (*sql.Conn).Raw with a structural
interface assertion, so no new database/sql plumbing is needed; args are
normalized with CheckNamedValue exactly as database/sql would.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* conn: deliver QueryResultContext rows as raw wire text

Rows produced by QueryResultContext now return every non-NULL cell as
its MySQL wire text ([]byte aliasing the connection buffer) instead of
parsing numeric and temporal columns into Go types. Proxy-style callers
forward values verbatim, so the parse/format round trip is pure
overhead — and it is lossy: zero dates become Go's zero time (year 1),
fractional-second padding is trimmed, and float formatting can drift
from the server's representation.

Regular Query/Exec paths are unchanged; the flag only exists on rows
that never pass through database/sql conversion.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* conn: reject named params and fix scan types on the unified path

Two divergences from the normal query path, both found in review.

QueryResultContext accepted driver.NamedValue with Name set an... (continued)

56 of 73 new or added lines in 3 files covered. (76.71%)

3439 of 4168 relevant lines covered (82.51%)

2573399.75 hits per line