biocore / scikit-bio

0%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

Reset

• master
• 0.2.1
• 0.2.2
• 0.2.3
• 0.2.4
• 0.4.0
• 0.4.1
• 0.5.0
• 0.5.1
• 0.5.2
• 0.5.3
• 0.5.4
• revert-1440-mixin
• revert-1445-im
• sprint
• update-conda-install
• windows-test

Build # 4072

Build Type

push

travis-ci-com

Committed by web-flow

Commit Message

BUG: Fix windows and 32bit support of `unweighted_unifrac` (#1729)

* BUG: Fix windows and 32bit support of `unweighted_unifrac`

This forces the tree `child_index` to be exported as 64bit and
also adds a cast (just in case) into `_nodes_by_counts` in the
`_phylogenetic.pyx` cython code.

I have tested that `unweighted_unifrac` succeeds with the change
to the `child_index`. I have not done a full test run, so while
this closes gh-1685, it is very likely that the similar issues
exist elsewhere.

Ideally, it would be great if you find the time to add an Azure job
for windows, or a 32bit job (which will at least find some of these
issues as well).

On a related note: Since this is an `index`, the correct dtype is
likely `np.intp`, which is 32bit on 32bit systems and 64bit on
64 bit systems. So it might be better if the cython `DTYPE_t` was
changed that (and the `child_index` code here as well), but
of course that relies on `DTYPE_t` not being used for anything
that is not an index operation but should have 64bit accuracy.

* MAINT: Regenerate diversity/_phylogenetic.c

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line