4072
0%

Ran 20 Oct 2020 05:00PM UTC

Jobs 6

Files 0

Run time 11min

Badge

Embed ▾

pending completion

Build # 4072

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

BUG: Fix windows and 32bit support of `unweighted_unifrac` (#1729)

* BUG: Fix windows and 32bit support of `unweighted_unifrac`

This forces the tree `child_index` to be exported as 64bit and
also adds a cast (just in case) into `_nodes_by_counts` in the
`_phylogenetic.pyx` cython code.

I have tested that `unweighted_unifrac` succeeds with the change
to the `child_index`. I have not done a full test run, so while
this closes gh-1685, it is very likely that the similar issues
exist elsewhere.

Ideally, it would be great if you find the time to add an Azure job
for windows, or a 32bit job (which will at least find some of these
issues as well).

On a related note: Since this is an `index`, the correct dtype is
likely `np.intp`, which is 32bit on 32bit systems and 64bit on
64 bit systems. So it might be better if the cython `DTYPE_t` was
changed that (and the `child_index` code here as well), but
of course that relies on `DTYPE_t` not being used for anything
that is not an index operation but should have 64bit accuracy.

* MAINT: Regenerate diversity/_phylogenetic.c

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs

ID	Job ID	Ran
1	4072.1 (CONDA_PY=3.8)	20 Oct 2020 05:00PM UTC	Travis Job 4072.1
2	4072.2 (CONDA_PY=3.7)	20 Oct 2020 05:01PM UTC	Travis Job 4072.2
3	4072.3 (CONDA_PY=3.6 USE_CYTHON=TRUE)	20 Oct 2020 05:01PM UTC	Travis Job 4072.3
4	4072.4 (CONDA_PY=3.8)	20 Oct 2020 05:11PM UTC	Travis Job 4072.4
5	4072.5 (CONDA_PY=3.7)	20 Oct 2020 05:11PM UTC	Travis Job 4072.5
6	4072.6 (CONDA_PY=3.6 USE_CYTHON=TRUE)	20 Oct 2020 05:12PM UTC	Travis Job 4072.6

Source Files on build 4072

Detailed source file information is not available for this build.

biocore / scikit-bio / 4072
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4072

biocore / scikit-bio / 4072 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4072

biocore / scikit-bio / 4072
0%

README BADGES
x