binarylogic / authlogic

24%

master: 96%

LAST BUILD ON BRANCH fix_load_early_error

branch: fix_load_early_error

CHANGE BRANCH

x

Reset

• fix_load_early_error
• 5-0-stable
• 5-1-stable
• 5-2-stable
• 6-0-stable
• 6-1-stable
• 6-2-stable
• 6-3-stable
• deprecate_find_by_login_method
• encrypted_cookies
• encrypted_cookies_5_1
• encrypted_cookies_6_0
• fix_ci
• issue_686
• master
• release-5.1.0
• release-5.2.0
• release-6.0.0
• release-6.1.0
• remove_dependency_on_scrypt
• thread_safety_726
• tiegz/doc-tweaks
• v5.0.2
• v5.0.3
• v5.0.4
• v5.1.0
• v5.2.0
• v6.0.0
• v6.2.0
• v6.3.0
• various_2020-03-23

Build # 702

Build Type

Pull #681

travis-ci

Committed by web-flow

Commit Message

Delete AuthlogicLoadedTooLateError

This error no longer seems to be necessary.

I tested this in a new rails 6.0.0 application. In the following,
my debug output is prefixed with "->".

```
bin/rails server
-> loading rails_adapter.rb
=> Booting Puma
...
* Listening on tcp://localhost:3000
...
-> RailsImplementation included into ActionController::Base
-> RailsImplementation included into ActionController::API
-> loading application_controller.rb
Started GET "/" for 127.0.0.1 at 2019-09-11 13:33:05 -0400
Processing by HomeController#index as HTML
-> activate_authlogic
  Rendering home/index.html.erb within layouts/application
```

We can see that the `activate_authlogic` callback still occurs. So,
raising an AuthlogicLoadedTooLateError would be incorrect.

And, of course, I tested a normal sign in POST.

Pull Request Pull Request #681: Delete AuthlogicLoadedTooLateError

Run Details

339 of 1415 relevant lines covered (23.96%)

2.16 hits per line