702
24%
master: 96%

Ran 11 Sep 2019 05:48PM UTC

Jobs 9

Files 40

Run time 4min

Badge

Embed ▾

pending completion

Build # 702

Build Type

Pull #681

travis-ci

Committed by

web-flow

Commit Message

Delete AuthlogicLoadedTooLateError

This error no longer seems to be necessary.

I tested this in a new rails 6.0.0 application. In the following,
my debug output is prefixed with "->".

```
bin/rails server
-> loading rails_adapter.rb
=> Booting Puma
...
* Listening on tcp://localhost:3000
...
-> RailsImplementation included into ActionController::Base
-> RailsImplementation included into ActionController::API
-> loading application_controller.rb
Started GET "/" for 127.0.0.1 at 2019-09-11 13:33:05 -0400
Processing by HomeController#index as HTML
-> activate_authlogic
  Rendering home/index.html.erb within layouts/application
```

We can see that the `activate_authlogic` callback still occurs. So,
raising an AuthlogicLoadedTooLateError would be incorrect.

And, of course, I tested a normal sign in POST.

Pull Request Pull Request #681: Delete AuthlogicLoadedTooLateError

Run Details

339 of 1415 relevant lines covered (23.96%)

2.16 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	702.1 (2.3.8, DB=mysql, gemfiles/rails_5.2.rb)	11 Sep 2019 05:48PM UTC	23.96	Travis Job 702.1
2	702.2 (2.6.1, DB=mysql, gemfiles/rails_5.2.rb)	11 Sep 2019 05:49PM UTC	23.96	Travis Job 702.2
3	702.3 (2.6.1, DB=mysql, gemfiles/rails_6.0.rb)	11 Sep 2019 05:50PM UTC	23.96	Travis Job 702.3
4	702.4 (2.3.8, DB=postgres, gemfiles/rails_5.2.rb)	11 Sep 2019 05:49PM UTC	23.96	Travis Job 702.4
5	702.5 (2.6.1, DB=postgres, gemfiles/rails_5.2.rb)	11 Sep 2019 05:50PM UTC	23.96	Travis Job 702.5
6	702.6 (2.6.1, DB=postgres, gemfiles/rails_6.0.rb)	11 Sep 2019 05:50PM UTC	23.96	Travis Job 702.6
7	702.7 (2.3.8, DB=sqlite, gemfiles/rails_5.2.rb)	11 Sep 2019 05:50PM UTC	23.96	Travis Job 702.7
8	702.8 (2.6.1, DB=sqlite, gemfiles/rails_5.2.rb)	11 Sep 2019 05:52PM UTC	23.96	Travis Job 702.8
9	702.9 (2.6.1, DB=sqlite, gemfiles/rails_6.0.rb)	11 Sep 2019 05:52PM UTC	23.96	Travis Job 702.9

Source Files on build 702

Detailed source file information is not available for this build.

binarylogic / authlogic / 702
24%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 702

binarylogic / authlogic / 702 24% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 702

binarylogic / authlogic / 702
24%
master: 96%

README BADGES
x