berkmancenter / mediacloud
64%
master: 70%

LAST BUILD BRANCH: release
DEFAULT BRANCH: master
Repo Added
Files 335
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pgcrypto_public
branch: pgcrypto_public
CHANGE BRANCH
x

5176

push

travis-ci

pypt 
Refer to pgcrypto's functions using schema name prefix to make pg_upgrade work

21:43 < pypt> Hi all! I'm trying to pg_upgrade from 9.6 to 10, and it fails at not being able to find "digest(text, text)" function from pgcrypto which is used by one of the indexes. Here's the excerp
t from our schema with the index layout: https://pastebin.com/DsBXuYpc. Without the offending index, pg_upgrade works fine (even with other cases where we use pgcrypto in the schema, none of which hap
pen to be in CREATE),
21:43 < pypt> and I'm not even sure why we use DIGEST(..., 'md5') instead of just MD5() here, but the index that is being created is just massive so I'm reluctant to recreate it. So the question is: i
s there a way to make pg_upgrade use pgcrypto's functions in CREATE INDEX statements, or do I have to go ahead and use "native" MD5() here instead?
21:44 < pypt> extra note: I can see CREATE EXTENSION statements in pg_upgrade's *.custom schema dump before the offending CREATE INDEX, and if I connect to half-upgraded 10.x database manually, digest
() function is available too
21:46 < RhodiumToad> pypt: this is fallout from the search_path security fixes
21:47 < RhodiumToad> pypt: the problem is that the index definition refers to a function which calls another function, and it's that _second_ call that fails because it relies on a search_path setting that isn't true inside the dump/restore
21:48 < RhodiumToad> pypt: if pgcrypto is installed in the public schema, then change the half_md5 function to use  substring(public.digest(...)...)
21:49 < pypt> RhodiumToad: thank you!

14401 of 22347 relevant lines covered (64.44%)

792.95 hits per line

Relevant lines Covered
22347 RELEVANT LINES 14401 COVERED LINES
792.95 HITS PER LINE
Source Files on pgcrypto_public
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
5176 pgcrypto_public Refer to pgcrypto's functions using schema name prefix to make pg_upgrade work 21:43 < pypt> Hi all! I'm trying to pg_upgrade from 9.6 to 10, and it fails at not being able to find "digest(text, text)" function from pgcrypto which is used by one ... push pypt travis-ci pending completion  
See All Builds (4335)