archetech / archon
93%
main: 94%

LAST BUILD BRANCH: ci/gatekeeper-parity
DEFAULT BRANCH: main
Repo Added
Token VKRdMqMwqPTOZprp4p5Cb3v3uLt6LWUtk regen
Build 1946 Last
Files 88
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH test/remaining-coverage-gaps
branch: test/remaining-coverage-gaps
CHANGE BRANCH
x
Sync Branches

coverage: 92.586% (+0.6%) from 91.941%
30722346806

Pull #825

github

macterra 
fix(gatekeeper): cancel the save timer when stop() fails, and close the last coverage gaps

Covers the four files still at 0% after #822 exposed them: the gatekeeper
json and json-cache backends, the keymaster wallet cache, and the didcomm
service config. No file in the repo now sits below 60%.

Writing those tests found a resource leak in DbJsonCache.stop():

    async stop() {
        this.saveDb();                 // throws if the write fails
        if (this.saveLoopTimeoutId !== null) {
            clearTimeout(...);         // never reached
        }
    }

A gatekeeper on the json-cache backend with an unwritable database cannot
shut down: stop() throws, the 20-second save timer stays armed, and the
process never exits — a hung container until the orchestrator kills it.
Found the hard way, by a test that hung for 400 seconds.

Fixed with try/finally so the timer is always cancelled while the save
error still reaches the caller, plus a regression test asserting
saveLoopTimeoutId is null after a failed stop.

Two construction-time behaviours are now documented by test, both of
which contradicted my initial assumptions:

- The constructor writes a file. loadDb() falls into its catch on a
  missing file and immediately saves an empty database, so disk is
  touched before any explicit save.
- The constructor throws when the data folder cannot be created, rather
  than deferring to saveLoop's catch, because that save runs during
  construction.

Left alone but worth noting: DbJsonCache.loadDb() reads and parses the
file twice, assigning dbCache from one parse and then overwriting it with
another. Wasteful, not incorrect.

Repo total 95.19% -> 95.85%.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Pull Request #825: fix(gatekeeper): cancel the save timer when stop() fails, and close the last coverage gaps

3482 of 4060 branches covered (85.76%)

Branch coverage included in aggregate %.

8157 of 8511 relevant lines covered (95.84%)

669.05 hits per line

Relevant lines Covered
8511 RELEVANT LINES 8157 COVERED LINES
669.05 HITS PER LINE
Source Files on test/remaining-coverage-gaps

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30722346806 test/remaining-coverage-gaps fix(gatekeeper): cancel the save timer when stop() fails, and close the last coverage gaps Covers the four files still at 0% after #822 exposed them: the gatekeeper json and json-cache backends, the keymaster wallet cache, and the didcomm service... Pull #825 macterra github
92.59
See All Builds (1939)