archetech / archon
89%
main: 94%

Repo Added 12 Jan 2026 07:43PM UTC

Token VKRdMqMwqPTOZprp4p5Cb3v3uLt6LWUtk regen

Build 1946 Last

Committed 01 Aug 2026 06:52PM UTC coverage: 89.383% (-3.6%) from 93.029%

Committed by

Commit Message

refactor(herald): extract the routes so index.ts can be tested

index.ts built its Express app at module scope and called app.listen() at
import time, so importing it booted the server. Its 34 routes were
untestable and uncounted — the last instance of the pattern #705, #706
and #819 fixed for the other services.

Split into three files:

- config.ts holds the environment-derived constants. Extracting these
  first meant the 38 constant references in the moved code needed no
  rewriting at all.
- routes.ts exports createHeraldRoutes(ctx), returning the router and
  startDmailPollLoop (the only symbol the bootstrap still needs).
- index.ts (1,490 -> ~210 lines) owns bootstrap only: app creation,
  session setup, service identity, database and keymaster wiring, listen.

keymaster, db, emailBridge and serviceDID are assigned after the routes
register, so they are read lazily through a HeraldContext object the
bootstrap populates.

Behaviour-preserving, verified rather than assumed: the block was moved
programmatically and diffed against the original with the same
transformations applied — it matches exactly, modulo indentation from
eslint --fix. The route set is identical (34 before, 34 after) and the
service's own `tsc -p tsconfig.json` is clean.

Two hazards worth recording. A naive \bkeymaster\b rewrite corrupted
import specifiers ('@didcid/keymaster' -> '@didcid/ctx.keymaster'), so
string literals are stashed before the identifier rewrite. And the object
shorthand `serviceDID,` became invalid syntax as `ctx.serviceDID,`; tsc
caught it, which is why the diff alone is not sufficient verification.

multer is declared in root devDependencies at herald's own ^2.2.0, so
routes.ts resolves in CI — services/* are not workspaces, so `npm ci`
never installs their dependencies.

42 tests cover the public endpoints, auth and owner gates, name
validation and the full name lifecycle (assign, credential issue vs
update, delete with revocation), webfinger, session l... (continued)

Coverage Stats

3483 of 4238 branches covered (82.18%)

Branch coverage included in aggregate %.

297 of 632 new or added lines in 2 files covered. (46.99%)

8059 of 8675 relevant lines covered (92.9%)

657.0 hits per line

8675 RELEVANT LINES 8059 COVERED LINES

657.0 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
30713503998	refactor/herald-router	refactor(herald): extract the routes so index.ts can be tested index.ts built its Express app at module scope and called app.listen() at import time, so importing it booted the server. Its 34 routes were untestable and uncounted — the last instan...	Pull #820	01 Aug 2026 06:55PM UTC	macterra	github	89.38

archetech / archon
89%
main: 94%

archetech / archon 89% main: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on refactor/herald-router

Recent builds

archetech / archon
89%
main: 94%

README BADGES
x

CHANGE BRANCH
x