alphagov / performanceplatform-admin

94%

master: 93%

LAST BUILD ON BRANCH new-move-and-remove

branch: new-move-and-remove

CHANGE BRANCH

x

Reset

• new-move-and-remove
• 73958164-flag-dashboard-admin
• 73958524-create-dashboard-form
• 73958524-create-module-form
• 76808354-bugfix-parsing-spreadsheets
• add-cache-control-no-cache
• add-coverage
• add-coveralls-badge
• add-dashboard-title-to-form
• add-development-signin
• add-digital-takeup-module
• add-drone-ci
• add-link-to-dashboard
• add-logging
• add-missing-ses-credentials
• add-quality
• add-save-and-continue-button
• add-sentry-tracking
• add-start-app
• add-user-satisfaction
• allow-local-development-config
• alphabetize-clone-modules-list
• alphabetize-things
• apply-dashboard
• apply-for-a-dashboard
• apply-for-a-dashboard2
• assign-owning-organisation-to-dashboard
• builder-cpt
• builder-hub-page
• bump-client
• catch-expired-token-403
• change-redis-prefix
• clone-a-dashboard
• clone-dashboard
• clone-module
• clone-module-final
• consolidate-permissions
• container-builds-and-cache
• copy-and-guidance-changes
• create-user-sat-data-set
• dashboard-editing
• dashboard-sections
• dashboard-unpublish
• desc-field-type
• digital-take-up-download
• error-formats
• extend-org-list
• feature/autopep8
• feature/builder-cost-per-tx
• feature/bump-client-version
• feature/delete-dashboard
• feature/fix-preview-deploys
• feature/handle-signon-reauth
• feature/new-dashboard-controller
• feature/upgrade-requests
• feature/upload-data-from-file
• feautre/signon-client-id
• fetch-environment-from-config
• fix-clone-dashboard
• fix-cpt-query-param
• fix-cpt-template-data
• fix-dashboards-with-no-org
• fix-expired-token-error
• fix-expired-token-problem
• fix-hub-page
• fix-js
• fix-lik
• fix-redirect-on-update
• fix-sign-out
• fix-unpublishing-of-dashboards
• fix/cpt-module-config
• fix/dataset-auto-ids
• fix/json_errors
• format-upload-data-timestamps-to-utc
• govuk-dev-vm
• group-by-group
• handle-failures-upload-data
• handle-no-signin-permission
• improve-docs
• improve-start-app-script
• improve-status-endpoint
• instant-preview
• list-dashboards-standalone
• list-data-sets
• list-my-datasets
• master
• module-type-templates
• move_title_to_top
• nice-page-when-no-signin-permission
• no-httmock
• old-template-fixes
• paas-migration
• prefill-visualisation
• pretty-print-json
• publish-dashboard
• query-params-fix
• re-restructure-admin-app
• reauth_wip
• record-notes-on-dashboard
• recover-missing-tests
• redis-on-travis
• remove-dataset-permission
• remove-duplicate-import
• remove-group-from-list
• remove-module
• remove-redis
• remove-redis-session
• remove-upload-logged-out
• reorder-modules
• reorder-modules-clean
• replicate-db-server-name
• restructure-app
• revert-admin-dataset-dropdown
• revert-revert-select-groups-and-types
• revert-select-groups-and-types
• rewrite-signed-in-decorator
• sass_that_works
• select-group-and-types
• select-groups-and-types
• send-correct-published-state
• send-dashboard-for-review
• sort-requirements
• spreadsheets
• standardised-error-messages-from-backdrop
• stop-retrying-requests
• template-fixes
• template-improvements
• template-words-and-urls
• templates
• temporary-single-cost-per-transaction-schema-fix
• tidy-dashboard-editing
• transform-dotfile
• tweak-copy-and-guidance
• typo-error-message
• ui-improvements
• update-backdrop-url
• update-log-file-location
• upload-a-spreadsheet
• upload-spreadsheets
• upload-status
• upload-wip
• use-real-env
• use-resource-view

Delete dashboard session on edit form

The 'pending_dashboard' session variable is used for passing saved state
from the create / update routes back to the form rendering routes. As
such it should only live for that single request. If the pending
dashboard stays in the session beyond that we risk showing unexpected
(and arguably incorrect) data in the form in certain situations. For
example, if a user goes back to the list page before saving and then
clicks back into the same dashboard the data shown would not be the data
that's stored in stagecraft but stale data from the session.