alphagov / notifications-admin

85%

master: 94%

LAST BUILD ON BRANCH flask-login-upgrade

branch: flask-login-upgrade

CHANGE BRANCH

x

Reset

• flask-login-upgrade
• 30-32-services
• 32-33
• 33-38
• 4-days-scheduled
• 4-days-scheduled-old
• 40-41
• 7days-reminder
• 8-char-password
• HEAD
• accept-common-spreadsheet-formats
• activity-improvements
• activity-page-refinements
• add-created_by-to-jobs
• add-crests
• add-date-range-filter-to-platform-admin
• add-delivery-and-failure-help-page
• add-domain
• add-email-domains-for-devs
• add-expand-collapse-to-send-guidance
• add-failure-rate-to-jobs
• add-ids-for-functional-tests
• add-information-security
• add-letters-templates
• add-letters-templates-2
• add-link-to-net-client
• add-lxml-to-req
• add-more-examples-email-template
• add-quarterly-breakdown
• add-redirect-for-email-verification
• add-slack-link
• add-spacer
• add-statsd
• add-ucds-domain
• add_created_by_to_api_calls
• ajax-activity-page
• ajax-patching
• align-dashboard-stats
• all-time-greatest-templates
• all-versions-link
• allow-partial-service-updates
• api-bumpf
• api-integration-index-page
• api-integration-page-FINAL
• api-key-types
• api-keys-page-improvements
• aria-tabs-pill-navigation
• aws-fixup
• banners-no-permissions
• beta-banner
• better-better-send-page
• better-choose-template
• better-error-message-if-accept-invite-but-signed-in
• better-errors-in-trial-mode
• better-flash
• better-send-page
• better-template-management
• better-two-factor-page
• better-wording-around-example
• big-number-no-show-more
• bold-by-month
• box-shadow-colour
• breaking-change
• bring-templates-into-admin
• british_time
• bug_fix_for_tour_back_button
• bump-utils-faster-csv
• bump-utils-vers
• button-spacing-mobile-fix
• cancel-button
• cancelled-jobs
• capita-whitelist
• case-insensitive-csv-headers
• catch-missing-statistics
• change-colours
• change-select-to-radio
• choose-time-to-schedule-job
• click-govuk-not-logged-in
• cloudfoundry
• code-coverage
• code-formatting-in-docs
• codedeploy_autoscaling
• column-fix
• commas-in-placeholders
• compress-all-js
• confirm-email-change
• contact-letter-block
• contact-link-signup
• contact-links
• contact-links-again
• cookie
• correct-innacurate-csv-error
• craig-david
• create-not-register
• custom_error_pages
• daily-limit-message
• dashboard-duration
• dashboard-link
• dashboard-stats-all-aligned
• dashboard-stats-untangling
• deactivate-service
• deactivate-services-all-services-list
• deactivate-services-plat-admin
• delete-button
• delete-template-bug
• delivery-info-specific-time
• deprecated-live
• deprecated-staging
• deskpro-department
• deskpro-user-email
• desktop_feedback
• detached
• detect-placeholders-in-email-subject
• different-human-timestamp-module
• dist-tests
• docIntegrateInfo
• doc_page_fix
• docker_build_http_proxy
• docs-in-app
• doctidy
• dont-create-normal-key-trial-mode
• dont-halt-gulp-on-errors
• download_all_job_notifications
• download_bug_fix
• download_csv_all
• download_job_notifications
• email-preview-endpoint
• email-regex
• email-registered-users
• environment-in-tickets
• example-template-is-priority
• explicit-about-sending-example-to-yourself
• failure-rate-jobs-page
• fancy-homepage
• feat-add-who-updated-providers
• feat-make-two-factor-use-new-update-password-endpoint
• feedback-flash
• feedback-page
• fetch-documentation
• filter-test-messages-jobs
• fitness
• fix-403-job-updates
• fix-500-notification-no-updated-at
• fix-50000
• fix-500s
• fix-activity-for-new-api
• fix-ajax-probs
• fix-alignment-usage
• fix-analytics
• fix-anchor-tag-in-flash
• fix-api-page-firefox
• fix-back-link-bug
• fix-blank-column-headers
• fix-change-email-bug
• fix-codedeploy-artifact
• fix-dashboard-page
• fix-deskpro-keys-staging-prod
• fix-display-of-jobs-on-dashboard
• fix-email-toggle
• fix-empty-table-width
• fix-forgot-password-empty-user-issue
• fix-get-started
• fix-html-entity-permissions
• fix-html-showing-up-breaking-change
• fix-invitation-bug
• fix-large-file-uploads
• fix-markdown-oddities
• fix-newlines-html-email
• fix-overlapping-on-notification-tables
• fix-page-title-api-info
• fix-page-title-send-test
• fix-paging-activity-page
• fix-param-tests
• fix-password-changed-at
• fix-recipient-column-error
• fix-research-mode-toggle
• fix-row-number-issue-on-report-download
• fix-single-template-usage
• fix-spacing-invite-confirmation
• fix-support-loop
• fix-table-display
• fix-template-graph-width
• fix-template-inheritance-without-navigation
• fix-top-keyline-tables
• fix-trial-mode-500
• fix-trial-mode-message
• fix_doc_link
• fix_environ_config
• fix_link_bug
• fix_template_subject_update_bug
• folded-letter
• footer-changes
• forget-me
• fork-weasyprint
• form-autocomplete-off
• format-failures
• freezegun
• generate-version-file-in-bootstrap
• go-live-page
• govuk-doc-prototype
• gsm
• gwen
• handle-new-jobs-api
• handle-new-template-stats-endpoint
• handle_api_response
• header-bar-colours
• header-colour-config
• header-pattern
• heading-level-template-stats
• hide-created-at
• hide-csv-on-dashboard-again
• hide-delivery-download-tour
• hmcts
• id-in-table
• ie-product-css-fixes
• import-cleanup
• improve-job-csv
• inactive-service
• info-security-and-design-patterns
• infosec-link
• install-reqs-from-wheels
• invitation-expiry-msg
• invite-accepted-bug
• invite-nongov-users
• jenkins_coveralls
• jenkins_deploy
• jenkins_deploy_dev
• jenkins_deploy_stage
• job_row_number
• jobs-on-dashboard
• js-memory-speedup
• js-updater-update
• junit-test-results
• keys
• keys-and-trial-mode
• label-template-statistics
• large-xl-fix
• last-used-message
• left-align-itemised-big-numbers
• letter-assets
• letter-hint
• letter-preview-with-placeholders
• letters-flag
• letters-nav
• limit-jobs-7-days
• link-service-count-to--perf
• link-to-status-page
• links-on-trial-mode-page
• live
• logging
• login-events
• make-activity-consistent
• make-forgot-your-password-text-consistent
• make-numbers-less-confusing
• make-settings-page-a-table
• make-tables-line-up
• make-total-default-on-job
• make_service_live
• master
• merge-fix-for-template-stats
• message-limit-increase-fix
• missing-columns-error
• more-rows-wording
• more_wording_changes
• move-guidance-underneath
• nbsp-fix
• new-api-for-deleting-templates
• new-api-key-format
• new-product-page
• new-tab-docs
• new_staging
• next-few-days
• no-banner-if-api-permission
• no-downtime-deploys
• no-jump-email
• no-tour-final
• no_permissions_banner_msg_fix
• non-bold-7-days-text
• notification-stats-day-admin
• notification_show_updated_at
• notifications_download_csv
• only-collapse-long-emails
• optional-content
• order-by-count-not-template-name
• origin/master
• origin/pr/914/merge
• outline-hmg-logo
• over-50000
• paas-master
• paas_awslogs
• paas_final_build
• page-title-fixes-missed
• paginate-dashboard
• pc-need-new-npm
• pdf-preview
• pentester-as-valid-domain
• permissions-bug-fix
• persist-letters
• placeholder-appearance
• placeholder-hint-sms
• plat-adm-stats
• plat-admin
• platform-admin-api-visibility
• platform-admin-dashboard
• platform-admin-list-services
• platform-admin-reorg
• platform-admin-stats
• platform-admins-invite-users
• point-documentation-at-clients
• populate-test
• previous-weeks
• pricing
• pricing-on-product
• primary-providers
• product-breadcrumb
• product-page-fixes
• proposition-image-meets-colour-contrast
• python-3.4-unpacking
• queued-is-a-thing
• quis-patch-1
• quis-patch-1-1
• rates
• rationalise-configs
• re-add-analytics
• readme-cleanup
• rearrange-breaking-change
• rearrange-csv-errors
• reason-for-mobile-on-invite
• reasons-for-failure
• record-request-time
• redirect-after-saving-template
• redirect-to-dashboard-when-existing-service
• refactior
• refactor-dashboard
• refactor-dashboard-extensive
• refactor-sending
• register-page-wording
• relabel-usage
• remove-all-services
• remove-code-that-handled-old-new-job-api
• remove-content-char-count
• remove-documentation
• remove-download-link
• remove-from-job-page
• remove-get-started-banner
• remove-human-timestamps
• remove-nl2br
• remove-noti-stats
• remove-old-key-info
• remove-session-protection
• remove-stats-from-job-page
• remove-stats-from-send
• remove-travis-image
• remove-unused-get_all_notificaitons
• remove-unused-items
• remove-unused-templates
• remove-unwanted-sass
• remove-user-from-service
• remove_ajax_calls
• removed-download-link
• rename-history
• replay-email
• reply-to-email
• reply-to-email-surfaced
• request-id-logging
• request-to-go-live-form
• request-to-go-live-improvements
• research-mode
• research-mode-platform-admin
• resend-verification-code
• reset_failed_login_count
• return-streamed-csv
• reverse-filters-activity
• revert-1163-unified-template-page
• revert-169-tabluar-big-number
• revert-833-js-memory-speedup
• revert-918-catch-missing-statistics
• revert-942-govuk-doc-prototype
• revert-969-dont-create-normal-key-trial-mode
• revert-976-revert-969-dont-create-normal-key-trial-mode
• revert-add-analytics
• revert-only-show-link-with-permissions
• revert-requirements
• revert-template-actions
• reword-homepage
• roadmap
• sanitize-html-in-templates-using-utils
• scotent
• send-api-key-type
• send-back-button
• send-back-in-help
• service-count-update
• service-email-fix
• service-name-tidy
• service-status
• session-id
• session-timeout
• set-branding-org
• set-sms-sender
• show-email-sms-stats-platform-admin
• show-last-updated-on-view-providers
• show-replaced-subject-if-in-CSV
• show-subject-choose-template
• sign-in-message
• sign-in-redirect
• single-template-view
• slack-link-update
• smarter-back-to-service-link
• sms-sender-fix
• sms-sender-job-page
• sms-sender-no-prefix
• sms_msg_limit
• sort-template-stats
• staging
• standardise-coding-examples
• stats-toggle-test-key
• statuspage-footer
• strong-2fa-security
• support-feedback-flow
• tables-of-notifications
• tabular-all-the-numbers
• tag-deploys
• team-id-for-deskpro
• temp-event-view
• temp-history-view
• template-guidance
• template-name-on-send
• template-previews
• template-stats-2
• template_history_view
• template_versions_link_design
• terms-of-use
• terms-of-use-updates
• terms-update
• test
• test-message-filtering
• test-message-not-run
• test2
• tidy-scss
• tidy-up-template-history
• timezones
• title-dashboard
• too-many-messages
• tour-footer-link
• tour-into-templates
• tour-to-dashboard
• travis-cache
• trial-mode-api-keys
• trial-mode-link-accessibility
• two-factor-bug-fix
• unbreak-my-change
• uncomment-out-tests
• unified-template-page
• update-api-client
• update-deskpro-key-name
• update-docs-for-auth-error-resp
• update-flask-login
• update-jobs-endpoint
• update-password-hints
• update-python-client
• update-readme
• update-requirements
• update-template-with-priority-if-platform-admin
• update-user-profile
• update-util-markdown-branding
• update-utils-nimbus
• update_for_db_rebase
• update_to_utcnow
• upgrade-govuk-template
• upgrade-pip
• upgrade-python-client
• upgrade-template
• upgrade-utils-bleach-fix
• upload_csv_into_one_bucket
• usage
• use-python-3-in-bootstrap
• use-wheels-to-speed-as-deployment
• use_host_uid_gid
• use_http_proxy_for_docker
• use_new_template_stats_endpoint
• utils-bump
• utils-bump-email-newline
• view-of-deleted-template
• virtualenv-for-aws
• visual-refactor-team-page
• visual-tidy-up
• week-activity
• weekly-refactor
• welsh-assembly
• whitelist-domain
• whitelist-domains
• whitelist-flash
• whitelist-live
• whitelisting-salesforce
• windows_csv
• wonky-tables
• xl-fix
• xlsx-spike
• yearly-template-usage
• you-make-me-feel-like-a-natural-england

Build # 2864

Build Type

push

travis-ci

Committed by ashimali

Commit Message

Update code to use lasest flask login.

In the process it seemed to me that the remember me checks weren't
quite right but was hidden by bug in is_authenticated in our User
model. That model returned False if login was not fresh.

However I think that should always return true for a User model as it
returns false for AnonymousUser objects.

To check for remember me instead check for login not being fresh
(which means in the current session user was loaded from cookie)

Additionally check for remember me in session being 'set'.

Changed test for remembered login as that test logged in user
properly but only session login fresh to false. That was
not correct. To mimic real behaviour the remember me cookie would
be set and notify_admin_remember_me would contain user id.

Run Details

1680 of 1975 relevant lines covered (85.06%)

0.85 hits per line