• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

alphagov / notifications-admin / 2864
85%
master: 94%

Build:
Build:
LAST BUILD BRANCH: fix-days-provider-history
DEFAULT BRANCH: master
Ran 03 May 2016 03:55PM UTC
Jobs 1
Files 51
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2864

push

travis-ci

ashimali
Update code to use lasest flask login.

In the process it seemed to me that the remember me checks weren't
quite right but was hidden by bug in is_authenticated in our User
model. That model returned False if login was not fresh.

However I think that should always return true for a User model as it
returns false for AnonymousUser objects.

To check for remember me instead check for login not being fresh
(which means in the current session user was loaded from cookie)

Additionally check for remember me in session being 'set'.

Changed test for remembered login as that test logged in user
properly but only session login fresh to false. That was
not correct. To mimic real behaviour the remember me cookie would
be set and notify_admin_remember_me would contain user id.

1680 of 1975 relevant lines covered (85.06%)

0.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2864.1 (auth_token=[secure]) 03 May 2016 03:55PM UTC 0
85.06
Travis Job 2864.1
Source Files on build 2864
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2864
  • fd1b5c1a on github
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc