alandtse / alexa_media_player

24%

dev: 24%

LAST BUILD ON BRANCH Rename-DataCache.set-method

branch: Rename-DataCache.set-method

CHANGE BRANCH

x

Reset

Sync Branches

• Rename-DataCache.set-method
• #-means-bridged-rationale-code-comment
• Clarify-cached-device-mutation-contract
• Fix-advanced-debugging-flag
• Fix-light/switch-toggle-lockout
• Refine-last_called-updates
• SupportNowPlaying
• Use-datetime.fromisoformat()
• add-restore_volume-service
• adj_media_image_url
• always-include-temperature-and-air-quality-sensors
• an-autouse-fixture-in-tests/test_sensor.py
• bump-alexapy-to-1.29.13
• bump-alexapy-to-1.29.14
• bump-alexapy-to-1.29.17
• bump_alexapy_to_1.29.16
• claude/debug-alexa-media-component-uEgi1
• claude/fix-alarm-panel-indexerror-JtwUr
• claude/fix-notify-keyerror-JtwUr
• claude/fix-reauth-error-state-JidpK
• claude/fix-test-ci-compatibility-1WSmu
• claude/fix-undefined-hue-emulated-enabled-Pvzno
• claude/identify-bugfix-e8ebZ
• claude/peer-review-bugs-jWjxn
• claude/prepare-upstream-bugfix-DuuRn
• claude/upstream-bugfix-pr-o9Fz9
• code-quality-improvements
• coderabbitai/docstrings/a027b74
• config_flow
• copilot/bump-alexapy-to-12912
• copilot/fix-2972
• danielbrunt57-patch-1
• danielbrunt57-patch-2
• dependabot/pip/authlib-1.6.4
• dependabot/pip/authlib-1.6.5
• dependabot/pip/authlib-1.6.6
• dependabot/pip/filelock-3.20.1
• dependabot/pip/filelock-3.20.3
• dependabot/pip/h11-0.16.0
• dependabot/pip/h2-4.3.0
• dependabot/pip/marshmallow-4.1.2
• dependabot/pip/pip-25.3
• dependabot/pip/pip-26.0
• dependabot/pip/pycares-4.9.0
• dependabot/pip/setuptools-78.1.1
• dependabot/pip/virtualenv-20.36.1
• deprecate-yaml-config
• deprecate_yaml
• detect-bridges
• dev
• diagsnotics.py-nosec-B105
• docs_fix-alexa-devices-comments
• error_communicating_with_api_notifications
• expose-echo-serial-frontend
• extended_entity_discovery
• feat-add-device-for-air-quality-sensors
• feat-add-diagnostics
• feat-readd-amazon-devices
• feat/entity-translations
• feature/get-nested-value-helper
• fix#3039
• fix#3042
• fix-TypeError-in-string-requires-string-as-left-operand
• fix-auth
• fix-deprecated-network-details
• fix-detection-of-home-assistant-matter-home
• fix-diagnostics.py
• fix-echo-dot-4th-gen-model-id
• fix-echo-show-11
• fix-handle-CancelledError
• fix-log-info-alexa-media-version
• fix-recurring-Authenication-required-by-Login-error-detected-in-alexapy
• fix-restore-amazon-air-quality-entities
• fix-sensor.py
• fix-smart-switch-declaration
• fix/broader-proxy-exception-handling
• fix/french-translation-sync
• fix/notification-sensor-unique-id
• fix/notifications-none-check
• fix/proxy-log-prefix
• fix_3125
• fix_5.5-6
• fix_air_quality_sensor
• fix_apicall
• fix_asyncio.CancelledError
• fix_error_communicating_with_API_notifications
• fix_group
• fix_helpers.py
• fix_login
• fix_otp_secret_in_config_flow
• fix_reauth
• fix_timer_alarm_reminder_sensors
• fix_tobstr_matter_hub_now_exposes_differently
• get_info
• handle_audioPlayerState
• hash-means-bridged-rationale-code-comment
• home-assistant-matter-hub
• increase_get_history_records_timeout
• kayodecker-patch-2
• lokalise-2026-01-12_11-48-52
• master
• media_player
• new_enable_network_discovery_service
• new_service_enable_network_discovery
• no-network-details
• obfuscate_email
• opt_import
• patch-1
• perf/optimize-boot
• pre-commit-ci-update-config
• previous_volume
• public_url
• py313
• refactor_debug_logging
• reformat-startup-message
• rel#2827
• require_otpsecret
• restore-include/exclude-filtering-for-media-player-switches
• revert-2670-public_url
• revert-3057-danielbrunt57-patch-2
• revert_3127
• revert_4.13.8_changes
• safety-update
• sayam93-patch-1
• sensor.py-debug-logging
• strengthen_notification_handling
• supported_feat
• traduction
• update_apexapy_1.29.15
• update_last_called_via_HTTP2PUSH_activity
• v4.13.6
• v4.13.7
• v4.13.8
• v5.0.0
• v5.0.1
• v5.0.2
• v5.0.3
• v5.0.4
• v5.0.5
• v5.1.0
• v5.10.0
• v5.11.0
• v5.12.0
• v5.12.1
• v5.12.2
• v5.12.3
• v5.14.0
• v5.2.0
• v5.3.0
• v5.4.0
• v5.5.0
• v5.5.1
• v5.6.0
• v5.7.0
• v5.7.1
• v5.7.10
• v5.7.11
• v5.7.12
• v5.7.13
• v5.7.2
• v5.7.3
• v5.7.4
• v5.7.5
• v5.7.6
• v5.7.7
• v5.7.8
• v5.7.9
• v5.8.0
• v5.8.1
• v5.8.2
• v5.8.3
• v5.8.4
• v5.9.0

Build # 22282439070

Build Type

Pull #3396

github

Committed by web-flow

Commit Message

Rename DataCache.set method to avoid shadowing built-in

Issue identified during review of PR #3390
Reported by: @coderabbitai
Requested by: @alandtse

Description:
In custom_components/alexa_media/metrics.py around lines 46-122, the DataCache.set method name shadows Python's built-in set type.

Current implementation:

def set(self, key: str, value: Any) -> None:
Suggested improvement:
Rename to a clearer name that doesn't shadow built-ins, such as:

cache_set
store
put
Impact:
Nitpick - No runtime problem since it's a method, but better practice to avoid shadowing built-ins for code clarity.

Reference:

PR: chore: release 2026-02-21 #3390
File: custom_components/alexa_media/metrics.py:46-122

Fixes: #3394

Pull Request Pull Request #3396: fix: Rename DataCache.set method to avoid shadowing built-in

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

1133 of 4765 relevant lines covered (23.78%)

0.24 hits per line