alandtse / alexa_media_player / 22282439070

24%

dev: 24%

Pull #3396

github

Rename DataCache.set method to avoid shadowing built-in

Issue identified during review of PR #3390
Reported by: @coderabbitai
Requested by: @alandtse

Description:
In custom_components/alexa_media/metrics.py around lines 46-122, the DataCache.set method name shadows Python's built-in set type.

Current implementation:

def set(self, key: str, value: Any) -> None:
Suggested improvement:
Rename to a clearer name that doesn't shadow built-ins, such as:

cache_set
store
put
Impact:
Nitpick - No runtime problem since it's a method, but better practice to avoid shadowing built-ins for code clarity.

Reference:

PR: chore: release 2026-02-21 #3390
File: custom_components/alexa_media/metrics.py:46-122

Fixes: #3394

1 of 1 new or added line in 1 file covered. (100.0%)

1133 of 4765 relevant lines covered (23.78%)

0.24 hits per line