adbrosaci / orm

92%

push

github

fix(TestHelper): avoid premature null-init of non-nullable wrapped properties in EntityCreator

EntityCreator::fill() called $entity->getProperty($key) for every wrapped
property to detect IRelationshipCollection. This triggered initProperty()
with a null raw value before the user-supplied value from $params was
applied, causing NullValueException for non-nullable properties using
value wrappers (e.g. DateTimeWrapper on a non-nullable createdAt).

Restrict the getProperty() call to collection relationships
(ONE_HAS_MANY, MANY_HAS_MANY) — the only ones backed by
IRelationshipCollection — using metadata instead of instantiating the
wrapper. Non-collection wrapped properties are now initialized directly
via setReadOnlyValue() with the supplied value.

5 of 5 new or added lines in 1 file covered. (100.0%)

4284 of 4648 relevant lines covered (92.17%)

5.42 hits per line