adana-coverage / babel-plugin-transform-adana

100%

master: 100%

LAST BUILD ON BRANCH separate-traverse

branch: separate-traverse

CHANGE BRANCH

x

Reset

• separate-traverse
• add-more-tags
• allow-no-instrument
• babel-7
• bump-version
• dump-guard
• fix-build-icons
• fix-computed-key-check
• fix-conditional-groups
• fix-ignore
• fix-return-try
• ignore
• jsx
• master
• object-methods
• pattern-guard
• refactor
• remove-mkdirp
• replace-hash-with-source
• split-dump
• try-catch-tags
• update-deps
• update-eslint
• update-travis
• v0.4.0
• v0.4.1
• v0.4.2
• v0.5.0
• v0.5.1
• v0.5.2
• v0.5.4
• v0.5.5
• v0.5.6
• version-bump

Build # 143

Build Type

push

travis-ci

Committed by izaakschroeder

Commit Message

Instrument code in separate `traverse` pass.

There is a bug (the origin of which I am unsure) whereby using adana as part of a preset results in no plugins being applied. My original thought was it had to do with `path.skip()` but even this seems not to be the case.

Looking at other plugins, everyone else seems to use `.traverse()` with a separate visitor; I emulated this and the problem seems to go away and everything still works. So that's what we're going with.

It appears this alters the instrumentation path somewhat as well, so more tests have been added to check against cases that are now no longer invoked by default. It also appears that `instrument` is now never called with an "invalid" (no location) entry, so the check has been removed. It may turn out that is totally wrong in which case a test will be added that actually manages to trigger it.

Run Details

372 of 372 relevant lines covered (100.0%)

39.42 hits per line