Stellarium / stellarium

11%

master: 11%

LAST BUILD ON BRANCH fix/SolarSystem-race

branch: fix/SolarSystem-race

CHANGE BRANCH

x

Reset

• fix/SolarSystem-race
• 0.19
• 0.4A.1
• 1202-solar-system-observer
• 1394-solstice-equinox-actions
• 1433-dso-data-handling
• 2157-indi
• 261_star_catalogs
• 32-wind
• 408-twilights
• 4202-install-without-admin-in-windows
• ASCOMAlpaca
• AstroCalc-qcharts
• CLI/no-screensaver
• Calendars/Byzantine
• DSO/v3.23
• Exoplanets-qcharts
• GHA/Maintenance
• GUI/font-reload
• GZ_star_trails
• LTO
• RemoteControl/windowSize
• SC/arabLM
• SC/byname
• SC/geojson
• SC/infoConstellation
• SH_AlmagestSkyculture
• SUG-foreword-25.1
• SUG/26.1
• SUG/JPL-Horizons
• SUG/fw25.4
• SUG/update-template
• Skycultures/tibetan_mansions
• TTS/set2
• aberration_range
• action/appimage
• action/coveralls
• action/de430_test
• action/transifex
• add_HA-grid
• african-sky-cultures
• allow-disable-sound
• allow-no-qtwebengine
• allow-reference-exclusion
• allow-texture-decimation
• app/vs2022
• appimage
• appimage-22
• appimage-ng
• appimage-qt5-u22
• appimage-qt6
• appimage-u18
• appimage/arm
• appveyor
• appveyor-experiments
• appveyor/windows-arm64-qt68
• archeolines-gui
• ascom-crash-fix
• astrocalc-almanac
• astrocalc-earth
• astrocalc-ephemeris-refactoring
• astrocalc-faster-findRightAscension
• astrocalc/almanac
• astrocalc/almanac-today
• astrocalc/ephemeris-now
• astrocalc/issue/3868
• autofix/alert-1-4cbf4d3198
• autofix/alert-2-a12ef76c44
• autofix/alert-20-4889f7e625
• autofix/alert-21-587dae6004
• autofix/alert-4-6615d8553c
• avoid-sun-streak
• aw-svg-experiments
• aw-travis-py3
• aw_observingLists
• aw_referenceManager
• aw_svgTextureSupport
• babylonian-sky-cultures
• cache-utcoffset
• calendars/RevisedJulian
• calendars/base-astro
• calendars/chinese
• calendars/new-hindu
• catalan-sc
• chinese-native-names
• chinese-pronounce-translation-simplification
• ci-linux
• ci-tests
• ci-unix
• ci/ci-workflow
• ci/freebsd
• ci/linux-arm
• ci/macOS
• ci/unix
• ci/windows
• ci/windows-qt69
• cifix/gpsd-macos
• clang-libc++
• cleanup_solarSystem
• clipboard-html
• cmake-exiv2
• cmake-precompiled-headers
• cmake/improvements
• colored_trails
• comet-icon_1315
• common-star-names
• cons-tr-restore
• coverity_scan
• cpp17
• cpp17-test
• current_vertical
• debian-packaging
• debian-packaging-qt6
• dimmer-nebula-hints
• directional-elongation
• docs
• dso-gui
• eclipse-artifacts-fix
• elvish-sc
• enhancement/astrocalc-positions
• ephemerides/htc20-theory
• ephemerides/rocky-moons
• ephemeris-line
• exclude-outdated-comets
• exoplanets-table-view
• exoplanets/extra-designation
• exoplanets/habitability
• exoplanets/proper-motion
• exoplanets/qcharts
• exoplanets/remove-diagram
• exoplanets/table-filters
• extraStrings
• faster-dso
• fasterOBJimport
• feature/transparent-landscapes
• finderscope-oculars
• fingerscope
• fix-2006
• fix-angularSize
• fix-gridline-labels
• fix-lunar-occultation
• fix-nebula-search
• fix-nomenclature-longitudes
• fix-planets-orbits
• fix-search-window-sluggishness
• fix-spheric-mirror-perf
• fix/1302
• fix/1945
• fix/3349
• fix/3970
• fix/4555
• fix/754
• fix/MilkyWayRebalance
• fix/MovementMgr
• fix/NO_GUI
• fix/ObsList-Import-Export
• fix/ObservingLists-GZ
• fix/RTS-noScaled
• fix/Sat-shadow-circle
• fix/SolarCorona
• fix/TelescopeControl_2713
• fix/Unified_ObsList
• fix/abortTelescopeSlew_LX200_NexStar
• fix/atmosphere-shader
• fix/bottom-bar-adapt-fontsize
• fix/disableASCOMqt6
• fix/draw_comet_orbits
• fix/earth-shadow-circles
• fix/edge-callback-labels
• fix/gravityLabels_u32
• fix/lessThreading
• fix/location_signals
• fix/model-rendering
• fix/new-connect
• fix/new-connect-core
• fix/orbit_details
• fix/rtl-infostring
• fix/screenshot-size
• fix/smooth_comet_orbits
• fix/unambiguous_comet_names
• fix/upvector-refix
• fix/waitForKeypress_4866
• fix_400
• fix_telrad
• fix_timezones_mess
• fix_win11-arm64
• for-deb-package
• format-log
• geonames-fix
• gestures-improvements
• gha/CodeQL-javascript
• gimbalOrbit
• gltf-compatible-normal-map
• gpsd-mac
• gravity-labels
• greatCirclePartitions
• greek-skyculture
• grids/ecliptic-calendar-marks
• ground_opacity-polygonal-landscapes
• gui-allow-user-css
• gui-show-focus
• gui/font-reload
• gui/fov
• gui/language-box
• guide/contributors
• guide/markdown
• guide/refs
• gz_AtmosphereTweaks
• gz_KeplerOrbit
• gz_NomenclaturePlotFixes
• gz_aberration
• gz_digression
• gz_planetAxes
• harden-userdir
• hips-performance
• hips-planet-name
• hips-remove-unloaded-invisible-tiles
• hips-z-fighting-fix
• htc20-theory
• imgbot
• immediate-store
• improve-orbit-selections
• improvement/4178
• indi-1.9.7
• info-fixes
• issue/2960
• issue/3199
• issue2762
• jplephem-race-fix
• json-oculars
• jump-to-defined-moments-in-diurnal-motion
• landscape-statics
• landscape-tint
• linux-fix
• loading-external-sc
• location-map-show-filter
• lto-flags
• macos13
• martian-poles
• master
• meteorshowers/activity-classes
• modern-english
• modernize-mesa
• moon-albedo-texture
• moreLogCategories
• narration
• navstars/custom-set
• neutral-geonames
• new-zoom-algo
• new_planet_magnitudes
• nextstar5
• nlopt-msvc2017
• nomenclature/information
• nomenclature/terminatorFixes
• observing-lists
• oculars-ng
• oculars/max-exposure-time
• oculus
• onlinequeries-secondscreen
• onlinequeries-webengine
• optional-compilation
• orbit-epoch
• paleolithic-sky-culture
• parallel-ephems
• planes
• planet-rts
• planet-rts-spaceship
• planet_properMotion
• planetary-hips-gui
• plg_OnlineQueries
• plg_archaeoLinesAdditions
• plg_calendars2
• plg_oculars_lineColor
• plugin/XEphem
• plugin/missing-stars
• plugin/oculars-actions
• plugin/oculars-fix-prism-rotation
• plugin/solarsystemeditor/comet-discovery-circumstances
• plugin_calendars
• polar-distance
• pole-markers
• pr-4915-evidence
• pr/4850
• pr/696
• pr/761
• printsky
• projection_plate_carree
• qt6/VideoMgr
• qtcompress
• quadrature
• qxlsx-update
• refactor-cardinals
• refactor-qflags
• refactoring/astrocalc-ephemeris
• refactoring/astrocalc-graphs
• refactoring/astrocalc-pc
• refactoring/astrocalc-positions
• refactoring/astrocalc-transits
• refactoring/compact-gui
• refactoring/grs-gui
• refactoring/gui-atmosphere
• refactoring/gui-grs
• refactoring/logger
• refactoring/mouse-navigation
• refactoring/objecttype
• refactoring/qcharts
• refactoring/qregexp
• refactoring/specific-time
• refactoring/stars-designations
• refactoring/tz-data
• refactoring/version-number
• refactoring/xlsx-optional
• references-manager
• refs/heads/exoplanets/habitability
• refs/heads/exoplanets/table-filters
• refs/heads/master
• refs/heads/plugin/missing-stars
• refs/heads/satellites/historical-data
• refs/heads/sso/discovery
• refs/tags/v0.20.4
• refs/tags/v0.21.0
• refs/tags/v0.21.1
• refs/tags/v0.21.3
• refs/tags/v0.22.0
• refs/tags/v0.22.1
• refs/tags/v0.22.2
• refs/tags/v1.0
• refs/tags/v1.1
• refs/tags/v1.2
• refs/tags/v23.1
• refs/tags/vendor/etwright/almagest/2007-06-14
• relative-button-scale
• release
• release-qt5
• remotecontrol/jquery
• remotecontrol/updating-webui
• remove-default-grs
• remove_QSignalMapper
• revert-2780-master
• revert-3438-one-sided-projection
• revising/comets
• right-click-buttons
• rocky-moons
• roman-skyculture
• satellites/altitude-range-visfilter
• satellites/filter-outdated-tle
• satellites/filters
• satellites/groups-from-url
• satellites/historical-data
• satellites/iss
• satellites/penumbra
• satellites/radiofrequency-editor
• satellites/sgp4-rev2020
• satellites/shadow
• satellites/table-view
• sc-conv-documentation
• sc/MorningEveningStar
• sc/convex-hulls
• sc/latin-names
• sc/multilabel
• sc/zodiac
• scene-tooltips
• scenery3d-key-doc
• scm-better-button-text
• scm-better-references
• scm-move-cons-descr
• scm/clearer-error-message
• script_clearSkyImages
• scripting-graphics-tool
• scripting/JSEngine
• scripting/change-planetary-texture
• scripting/dome-mode
• showmysky-data
• siberian-pronounce
• skyculture/blackfoot
• skyculture/botswana
• skyculture/bugis
• skyculture/catalan
• skyculture/egyptian_dendera
• skyculture/khoi-san
• skyculture/license-info
• skyculture/mandar
• skyculture/ruelle
• skyculture/russian
• skyculture/samoan
• skyculture/xhosa
• skyculture/zulu
• skycultures-new-format
• skycultures/modern-english
• skycultures/modern_iau
• skycultures/regions-option
• skycultures/seri
• small-tile-hips
• smh_Chenzhou
• solar-lunar-info
• solar-system-automatization
• solarSystemEditor
• solarsystemeditor/comet-discovery-circumstances
• speedup/planetID
• speedup_renderMarkerPointedCircle
• sso/discovery
• standard-cpp17
• stars-sf-cdn
• stars/bayer-flamsteed-designations
• stars/gcvs
• stars/wds
• stellarium-25.1-linux
• stellarium-bionic
• stellarium-next
• stellarium-oldstable
• stellarium-stable
• stellarium-stable-arm64
• sun-texture
• survey-filter
• survey-filter-by-enabled-state
• sushoff-newGreek
• telescope-ascom-alpaca
• texture-fix-load-error
• texture-loading-without-lags
• threaded-ephems
• tle-to-csv
• towards-Qt6
• transifex-archive
• travis-experiments
• tui-fixes
• tz-Asia-Choibalsan
• u20-libtbb
• ui/astrocalc-buttons
• ui/config-view
• ui/daymode
• ui/financial-contributors
• ui/fov
• ui/grids-checkboxes
• ui/noto-fonts
• ui/specific-time
• update-mesa
• use_qt_positioning
• useful-observer-orientation
• v0.20.0
• v0.20.1
• v0.20.2
• v0.20.3
• v24.4
• v25.1
• v25.2
• v25.3
• v25.4
• v26.1
• v26.2
• vanuatu-skyculture
• vecmath_fixes
• version-scheme
• visualisation/draw-point-source
• vts-plugin
• wayland-fractional-scaling
• weather-plugin
• win-qt64
• windows-arm64
• windows-ci
• windows-ci-win32
• windows-deployment
• windows-hipdi
• windows-packaging
• windows/mingw
• windows/msvc-dll
• windows/qtwebengine
• xlsx-optional
• zlib-1.3.2

Build # 27712648160

Build Type

Pull #4950

github

Committed by gzotti

Commit Message

Prevent occasional race condition in SolarSystem::computePositions()

I was already pretty sure where to investigate: Moons, after all.
This solution was proposed by Claude Code.

This commit is as-is (including extensive comments discussing the changes),
but needs testing, and yes, some comments can be even shortened.

Pull Request Pull Request #4950: Prevent occasional race condition in SolarSystem::computePositions()

Coverage Stats

55 of 155 new or added lines in 6 files covered. (35.48%)

1000 existing lines in 7 files now uncovered.

14747 of 135998 relevant lines covered (10.84%)

12266.05 hits per line